Skip to content

Commit

Permalink
Unit Tests: Ensure that apply_filters is extracted, and that the pa…
Browse files Browse the repository at this point in the history
…rameters to it are as well. (#239)

* Add a apply_filters() unit test.

* Add a way to test that the arguments are extracted.

* Add test groups
  • Loading branch information
dd32 authored Jan 18, 2024
1 parent 306166a commit e30c309
Show file tree
Hide file tree
Showing 8 changed files with 36 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tests/phpunit/includes/export-testcase.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,13 @@ protected function assertEntityContains( $entity, $type, $expected ) {
foreach ( $entity[ $type ] as $exported ) {
if ( $exported['line'] == $expected['line'] ) {
foreach ( $expected as $key => $expected_value ) {
$this->assertEquals( $expected_value, $exported[ $key ] );
if ( isset( $exported[ $key ] ) ) {
$exported_value = $exported[ $key ];
} else {
$exported_value = _wp_array_get( $exported, explode( '.', $key ), null );
}

$this->assertEquals( $expected_value, $exported_value );
}

return;
Expand Down
3 changes: 3 additions & 0 deletions tests/phpunit/tests/export/docblocks.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

/**
* Test that docblocks are exported correctly.
*
* @group export
* @group export-docblocks
*/
class Export_Docblocks extends Export_UnitTestCase {

Expand Down
1 change: 1 addition & 0 deletions tests/phpunit/tests/export/hooks.inc
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ do_action( "action_with_double_quotes" );
do_action( $variable . '-action' );
do_action( "another-{$variable}-action" );
do_action( 'hook_' . $object->property . '_pre' );
apply_filters( 'plain_filter', $variable, $filter_context );
13 changes: 13 additions & 0 deletions tests/phpunit/tests/export/hooks.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

/**
* Test that hooks are exported correctly.
*
* @group export
* @group export-hooks
*/
class Export_Hooks extends Export_UnitTestCase {

Expand Down Expand Up @@ -35,5 +38,15 @@ public function test_hook_names_standardized() {
$this->assertFileContainsHook(
array( 'name' => 'hook_{$object->property}_pre', 'line' => 7 )
);

$this->assertFileContainsHook(
array(
'type' => 'filter',
'name' => 'plain_filter',
'line' => 8,
'arguments.0.name' => '$variable',
'arguments.1.name' => '$filter_context'
)
);
}
}
3 changes: 3 additions & 0 deletions tests/phpunit/tests/export/namespace.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

/**
* Test that hooks are exported correctly.
*
* @group export
* @group export-namespace
*/
class Export_Namespace extends Export_UnitTestCase {

Expand Down
3 changes: 3 additions & 0 deletions tests/phpunit/tests/export/uses/constructor.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

/**
* Test that use of the __construct() method is exported for new Class() statements.
*
* @group export-uses
* @group export-uses-constructor
*/
class Export_Constructor_Use extends Export_UnitTestCase {

Expand Down
3 changes: 3 additions & 0 deletions tests/phpunit/tests/export/uses/methods.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

/**
* Test that method use is exported correctly.
*
* @group export-uses
* @group export-uses-methods
*/
class Export_Method_Use extends Export_UnitTestCase {

Expand Down
3 changes: 3 additions & 0 deletions tests/phpunit/tests/export/uses/nested.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

/**
* Test that function use is exported correctly when function declarations are nested.
*
* @group export-uses
* @group export-uses-nested
*/
class Export_Nested_Function_Use extends Export_UnitTestCase {

Expand Down

0 comments on commit e30c309

Please sign in to comment.