Adds a new isType(string $type): bool method to the File DTO, enabling specific MIME type checking beyond the existing predefined type methods.
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the isType(string $type): bool method to the File DTO, allowing checks for specific MIME types. Also improves comments and formatting around data URI handling.
Extended the FileTest unit test to include assertions for the isType method, specifically verifying correct type detection for 'video', 'image', 'audio', and 'text'.
felixarntz
requested changes
Aug 5, 2025
There was a problem hiding this comment.
@JosephGabito Thank you for the PR! I like that idea, only one point of feedback to clarify the purpose.
Refactored the File DTO method isType to isMimeType for clarity. Updated all relevant unit tests to use the new method name.
Updated the docblock for the type parameter in the File DTO to specify that it expects a mime type (e.g. 'image', 'text', 'video', 'audio'). This improves code documentation and developer understanding.
|
@felixarntz Updated the method name to isMimeType() and adjusted the docblock + test assertions accordingly. Let me know if there's anything else you'd like me to tweak. Thanks 🙌 |
felixarntz
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
isType(string $type): boolmethod to the File DTO class, enabling specific MIME type checking beyond the existing predefined type methods.Changes
File::isType(string $type): bool- delegates to MimeType object for flexible type checkingtestMimeTypeMethods()to include assertions for the newisType()methodTesting
testMimeTypeMethods()