-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset admin pointer dismissal for module migration when the user activates a module #915
Reset admin pointer dismissal for module migration when the user activates a module #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @mukeshpanchal27. Looks close, I have one performance thing worth addressing here and another functional concern that could however also be addressed in a separate follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 LGTM, but let's follow up on the user conversation, potentially with a follow up PR once we have agreed on the approach.
Summary
Follow-up to #910 (comment)
The PR introduced the capability to "un-dismiss" a pointer when a user activates a module. Within the code, the
perflab_run_module_activation_deactivation
function is utilized, triggered upon saving settings for the Performance Lab.Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.