-
Notifications
You must be signed in to change notification settings - Fork 135
Add AGENTS.md
and AI contribution guidance
#2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
AGENTS.md
and AI guidance
AGENTS.md
and AI guidanceAGENTS.md
and AI contribution guidance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a couple small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter Happy to see this, thanks for setting it up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two high-level suggestions:
- Add a section to cover some key architectural concerns (e.g. no OOP, follow WordPress Core procedural programming patterns) and directory overview (how things in different places tie together, e.g. "each
plugins/*
folder is a separate WordPress plugin" etc). - Use more examples instead of long explanations for things like code style, using functions to print scripts, etc.
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: Felix Arntz <[email protected]>
Co-authored-by: Felix Arntz <[email protected]> Co-authored-by: John Parris <[email protected]>
Co-authored-by: Felix Arntz <[email protected]>
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
||
## Use of AI Tools | ||
|
||
<!-- Please disclose whether AI tooling was used to author the code in the pull request. To what extent was AI used? Was it used as a code reviewer, or was it used to "vibe code" everything? It is your responsibility to review and take responsibility for what AI generates. For more, see CONTRIBUTING.md which includes instructions for how to provide instructions to AI agents. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you apply https://github.com/WordPress/performance/pull/2193/files#r2389568757, it should probably be put here too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 1fa61f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this was a misunderstanding - the copy here is still the old one, it needs to be aligned with what's in CONTRIBUTING.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Humm. I seemed to have missed making the change I imagined myself making! Now addressed in 688a21c
Co-authored-by: Felix Arntz <[email protected]>
Co-authored-by: Felix Arntz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. A few more points of feedback.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
||
## Use of AI Tools | ||
|
||
<!-- Please disclose whether AI tooling was used to author the code in the pull request. To what extent was AI used? Was it used as a code reviewer, or was it used to "vibe code" everything? It is your responsibility to review and take responsibility for what AI generates. For more, see CONTRIBUTING.md which includes instructions for how to provide instructions to AI agents. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this was a misunderstanding - the copy here is still the old one, it needs to be aligned with what's in CONTRIBUTING.md
.
Co-authored-by: Adam Silverstein <[email protected]>
Co-authored-by: Adam Silverstein <[email protected]>
Co-authored-by: Felix Arntz <[email protected]>
Co-authored-by: Felix Arntz <[email protected]>
Anything more for this initial version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with this and iterate as we identify areas to improve :)
This adds an
AGENTS.md
as was recently done for Gutenberg: WordPress/gutenberg#71796It also updates the
CONTRIBUTING.md
andPULL_REQUEST_TEMPLATE.md
to provide guidance on how AI tools should be used and how their use should be disclosed.I incorporated parts of my
.gemini/styleguide.md
from mywp-plugin-template
repo.An initial draft of
AGENTS.md
was created via Gemini CLI creating aGEMINI.md
via/init
.