-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental flags from Embed Optimizer and Image Prioritizer #1846
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1846 +/- ##
=======================================
Coverage 65.92% 65.92%
=======================================
Files 88 88
Lines 6885 6885
=======================================
Hits 4539 4539
Misses 2346 2346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter LGTM, just one nit-pick.
README.md
Outdated
[Embed Optimizer][5] | `embed-optimizer` | No | [Source][13], [Issues][21], [PRs][29] | ||
[Image Prioritizer][7] | `image-prioritizer` | No | [Source][15], [Issues][23], [PRs][31] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-pick, but we may want to keep these alphabetically sorted (I.e. integrate in the list items above), with experimental plugins at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point. Fixed in b8d1019
Co-authored-by: felixarntz <[email protected]>
The currently-released version of Optimization Detective plugin is 1.0.0-beta1. Optimization Detective, Embed Optimizer, and Image Prioritizer all 20,000+ active installs respectively. Analysis of these plugins on sites in HTTP Archive has shown them to be effective at improving performance. The plugins running in the wild has not resulted in major issues that would put their stability into question. Therefore, it's time to remove the experimental labels from these plugins.
In a subsequent PR for the next Performance Lab release we may bump Image Optimizer and Embed Optimizer to 1.0.0-beta1 as another indication of the maturity for these plugins.