Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental flags from Embed Optimizer and Image Prioritizer #1846

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Feb 4, 2025

The currently-released version of Optimization Detective plugin is 1.0.0-beta1. Optimization Detective, Embed Optimizer, and Image Prioritizer all 20,000+ active installs respectively. Analysis of these plugins on sites in HTTP Archive has shown them to be effective at improving performance. The plugins running in the wild has not resulted in major issues that would put their stability into question. Therefore, it's time to remove the experimental labels from these plugins.

In a subsequent PR for the next Performance Lab release we may bump Image Optimizer and Embed Optimizer to 1.0.0-beta1 as another indication of the maturity for these plugins.

image

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) labels Feb 4, 2025
@westonruter westonruter added this to the performance-lab n.e.x.t milestone Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.92%. Comparing base (e793289) to head (b8d1019).
Report is 15 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #1846   +/-   ##
=======================================
  Coverage   65.92%   65.92%           
=======================================
  Files          88       88           
  Lines        6885     6885           
=======================================
  Hits         4539     4539           
  Misses       2346     2346           
Flag Coverage Δ
multisite 65.92% <100.00%> (ø)
single 38.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter LGTM, just one nit-pick.

README.md Outdated
Comment on lines 18 to 19
[Embed Optimizer][5] | `embed-optimizer` | No | [Source][13], [Issues][21], [PRs][29]
[Image Prioritizer][7] | `image-prioritizer` | No | [Source][15], [Issues][23], [PRs][31]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick, but we may want to keep these alphabetically sorted (I.e. integrate in the list items above), with experimental plugins at the end.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point. Fixed in b8d1019

Co-authored-by: felixarntz <[email protected]>
@westonruter westonruter merged commit 68c6deb into trunk Feb 5, 2025
18 of 19 checks passed
@westonruter westonruter deleted the remove/experimental-flags branch February 5, 2025 01:08
westonruter added a commit that referenced this pull request Feb 11, 2025
@westonruter westonruter mentioned this pull request Feb 11, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants