Automatically opt into 1536x1536 and 2048x2048 sizes when generating fallback images #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ink0
requested review from
adamsilverstein,
felixarntz and
westonruter
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
added
[Type] Enhancement
felixarntz
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
@b1ink0 This basically looks good to me, only two outstanding comments to address.
felixarntz
added
[Plugin] Modern Image Formats
…comment about usage of global
mukeshpanchal27
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1512
Relevant technical choices
This PR automatically opt into 1536x1536 and 2048x2048 sizes when generating fallback images. This only happens when the "generate fallback images" is enabled.
The opt in is done by modifying the
$_wp_additional_image_sizesglobal which is the array containing extra image sizes. Theprovide_additional_mime_typesproperty is set to true for the 1536x1536 and 2048x2048 image sizes so that the selected modern image format of these sizes is also generated.Before
For the demo img these images were generated ( fallback images is enabled )
After
For the demo img these images are now generated ( fallback images is enabled )
