-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Performance screen when external requests to WordPress.org fail #1474
Improve Performance screen when external requests to WordPress.org fail #1474
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @chimok. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter +1 to this nice little UX improvement for when things are broken :)
This reminds me that it would be great to avoid all these individual requests. The more plugins we add, the more of a bottleneck / failure risk they'll become.
I don't think wordpress.org has an API endpoint to get the same data for multiple plugins in bulk, but exploring Requests::request_multiple()
might be a good idea. On the other hand, this would require some hacks because the way WordPress core wraps the regular Request::request()
method makes for different behavior. I wish WordPress core just had wp_request_multiple()
... 😮💨
@westonruter The wp_admin_notice return empty |
Co-authored-by: Weston Ruter <[email protected]>
Fixes #1473.
With the following plugin code active:
Before:
After: