Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Uploads: Cover block #399

Closed
StevenDufresne opened this issue Feb 22, 2022 · 2 comments
Closed

Media Uploads: Cover block #399

StevenDufresne opened this issue Feb 22, 2022 · 2 comments
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview

Comments

@StevenDufresne
Copy link
Collaborator

Describe the bug

  • The cover block utilizes the BlockControls slot and inserts <MediaReplaceFlow>(Ref).
  • The <MediaReplaceFlow> adds the ability upload assets if the user has upload permissions detemined in <MediaUploadCheck>

Question: Will be modifying upload permissions or do we need to hide this functionality?

Screenshot
@StevenDufresne StevenDufresne added the [Component] Pattern Creator Anything related to the pattern front end editor or preview label Feb 22, 2022
@ryelle
Copy link
Contributor

ryelle commented Feb 22, 2022

Uploads should already be prevented from #373 (see #37), this sounds like a regression.

@StevenDufresne
Copy link
Collaborator Author

Aha. My apologies, works as expected in editor mode. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryelle @StevenDufresne