Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a library of media and only allow that to be used in patterns #37

Closed
ryelle opened this issue Jan 19, 2021 · 5 comments · Fixed by #373 or #375
Closed

Create a library of media and only allow that to be used in patterns #37

ryelle opened this issue Jan 19, 2021 · 5 comments · Fixed by #373 or #375
Assignees
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview

Comments

@ryelle
Copy link
Contributor

ryelle commented Jan 19, 2021

We have #23 for the idea of setting up asset placeholders (cover block, images, etc) where the end user would add in their own image, but it's also likely that pattern authors will want to add their own assets as part of the pattern (a cover block with a highly designed background image).

  • Should we allow asset (image, video, audio, …?) uploads to w.org through the creator?
  • Maybe only allow the "Insert from URL", with users uploading media elsewhere?
  • Safelist the allowed URLs?
  • What if the content at the URL changes/disappears?

Checking for inappropriate material & licensing will be tracked in #22, but could also be part of the upload step here

@ryelle ryelle added the [Component] Pattern Creator Anything related to the pattern front end editor or preview label Jan 19, 2021
@ryelle
Copy link
Contributor Author

ryelle commented Jan 19, 2021

This is the list of approved sites for stock photos from the theme review guidelines.

I was thinking about integrating a stock photo site & disallowing uploads, but that wouldn't help the hypothetical person who designs a custom background or header image for the pattern.

@ryelle ryelle added the [Type] Discussion Proposed idea, needs input from others before actionable label Mar 30, 2021
@shaunandrews
Copy link
Collaborator

I think we need to restrict uploads and provide a collection of worry-free assets (images, videos, audio, files) in the media library. We can highlight this in the welcome guide and in media block placeholders:

image

image

A good next step would be to integrate some sort of search with a worry-free stock provider, like the approved list you linked to.

@ryelle ryelle added this to the Initial Launch milestone Apr 26, 2021
@ryelle ryelle changed the title Uploading assets for use in patterns Create a library of media and only allow that to be used in patterns Apr 26, 2021
@ryelle ryelle removed the [Type] Discussion Proposed idea, needs input from others before actionable label Apr 26, 2021
@ryelle ryelle self-assigned this Sep 8, 2021
@ryelle ryelle removed their assignment Oct 19, 2021
@ryelle ryelle self-assigned this Oct 25, 2021
@zackkrida
Copy link
Member

Just chiming in that Openverse seems like a natural fit well-suited for this task! The only caveat there is that we support all Creative Commons licenses, even those that require attribution. Users would need to be sure to include these attributions (which we make easy with a 1-click copy/paste attribution tool) or use CC0 images exclusively.

We have some dramatic improvements to search result quality coming live in the following week, particularly as related to stock photography search terms (nature, flowers, wallpapers, background, love, and so on) but that affect all searches. I'll send out a ping here when those are live.

Additionally, we currently only support images, but will be launching audio by the end of the year, with plans for video and 3d models next year.

@ryelle
Copy link
Contributor Author

ryelle commented Oct 27, 2021

@zackkrida The long-term plan has been to use Openverse, so that's great to hear. Is there an integration in gutenberg that we can use?

Users would need to be sure to include these attributions (which we make easy with a 1-click copy/paste attribution tool) or use CC0 images exclusively.

Would it be possible to restrict the results to just the CC0 assets? There won't be any validation to check that pattern authors are correctly attributing things, so it would be easier for moderation if we can stick with just CC0.

@zackkrida
Copy link
Member

@ryelle No Gutenberg integration yet. Results could however definitely be limited to CC0. This kind of filtering is avaliable in both the UI:

and through Openverse's public API:

There's some prior art on using Openverse (back when it was CC Search) as part of the Jetpack "External Media Library" feature (the code was written but it was never implemented) so that could be a fast track to integration, otherwise I think what exactly Openverse will look like within core is a very open question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview
Projects
None yet
3 participants