Add a grey block for the editor preview. #51
Conversation
|
|
||
| const EditView = ( { className } ) => { | ||
| return ( | ||
| <div className={ className }> |
There was a problem hiding this comment.
There's a Placeholder component you could use for this: https://github.com/WordPress/gutenberg/tree/master/packages/components/src/placeholder
There was a problem hiding this comment.
For some reason, the icon that comes out of the icon package and the dashicon that is provided to the block config are different. I definitely want to keep the icon because when it's not focused, it's not evident that the block is related.
It's also a bit confusing to me that the @wordpress/icons package doesn't resolve unless its explicitly installed. Any idea what's going on there?
There was a problem hiding this comment.
I just tried out <Placeholder icon="calendar" label="Placeholder"> enclosing the text, and got matching icons:
I have no idea why, just blindly copying code.
There was a problem hiding this comment.
Weird. The example has the SVG exported and then the reference passed in. I guess, if you just pass the string it falls back to dashicons. That's unexpected. I can update.
There was a problem hiding this comment.
Yeah, that's apparently how it works:
There was a problem hiding this comment.
i think they've been updating to move away from dashicons in general, so @wordpress/icons is a new package of new icons, but it's still in transition — see WordPress/gutenberg#20464
It's also a bit confusing to me that the @wordpress/icons package doesn't resolve unless its explicitly installed.
Might be a versioning issue, if you're not using the GB plugin, or using an older version.
|
Prefer #60 |
This PR: