feat: Save data offline (close #7367) #9383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
reviewed
Aug 28, 2018
|
|
||
| describe( 'storage', () => { | ||
| it( 'should work', () => { | ||
| expect( true ).toEqual( true ); |
There was a problem hiding this comment.
Well I mean, it passes! 🤪
tofumatt
force-pushed
the
try/save-data-offline-7367
branch
from
0dcdba8
to
0ce9063
Compare
gziolo
added
[Status] Stale
|
I don't think @tofumatt still works on this PR. @mtias and @youknowriad what's the plan for this feature? |
|
I think it'll be something to revisit and this could serve as prior art, but the specific implementation will need considerable revisions to account for more recent refactorings to eliminate post effects (#13716). I'd suggest it be closed with continued discussion to take place at the associated issue #6322. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental and still a work-in-progress.
Description
Experiment to save data offline for autosaves and saves when there is no network connection.
That part works and the UI doesn't complain about failures, but we'll likely want to:
How has this been tested?
Locally in Firefox only so far; it may not work in other browsers as the off-line check relies on the error message in the Fetch API… and I'm not sure they're consistent across browsers.
Screenshots
Coming later...
Types of changes
This is a new feature and part of #6322.
Checklist: