-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Heading Block description #9179
Update Heading Block description #9179
Conversation
Could you share screenshots of the things you think should be changed? And do you have proposed language (it's fine if you don't)? Thanks! |
@michelleweber These headings are used inside the page content to divide it, not above it. |
Perfect, thanks. I'll offer tweaks that you can take or leave; your suggested changes are clear, but I'd love to bring the tone more in line with the other descriptions. Heading: Help visitors (and search engines!) understand what they're reading with a short description. I still like the subhead description, but if you want something more pointed: Subheading: Add a subtitle above a section of your content to introduce your next topic and help readers follow the flow. (Personally, I'm not sure the user needs to know at this point that the heading is used for SEO, I think they just need to know what happens when they insert this block. So my instinct would be either to save the space and remove that, or include it as a parenthetical to make it clear that it's supplemental info.) |
One note about the subheading block is that it can only be used once (see #8140). |
@chrisvanpatten yeah.. that's really not apparent, I think #8140 needs reopened. As indicated in that PR and in the audit in #8234 (which suggests killing it), it's super confusing when to use it. Also, it seems strange that a Subheading is simply a I appreciate the value, I've built plenty of news sites with those subheading decks, but without a way to really explain itself easily and the nuance between it and say an |
It's not semantically a heading though :) But yes I agree about reopening #8140 and totally appreciate the confusing name. |
Yes, the envisioned use isn't a semantic As subtitle or deck it's much less confusing. It's totally reasonable to assume Subheading would refer to some form of |
For this PR, I've reverted changes to the Subheading block to make the correction to the Heading block only @michelleweber, however the new description doesn't really speak to section-ing the document and kinda sounds like an excerpt. |
I do not either of these descriptions work. It sounds like some kind of meta description. A heading is definitely not a short description of the content that follows. It is the title of a section of a document... or in other words, the heading of a section of a document. How about something like this: Use a heading to add a title to a section of content. Or alternatively: Add a title to a section of content with a heading. Or how about this: Use headings to divide your content into named sections. |
Heading: Help visitors (and search engines!) understand what they're reading. Add headlines to introduce your topics and help readers follow the flow. And for subhead, the original subhead text plus "Use it under a heading to add context." for more clarity. |
@michelleweber thank you for your patience 😌 I think these are getting nicely refined. If I may be a bit picky, Headings could be used to title Video/Embed blocks, Audio/Playlist blocks, etc, so I'm not sure about I hesitate to update the Subheading in this PR if #8140 is being reopened as @chrisvanpatten indicated, so that can be a separate PR. As-coded, the block can only be inserted once, intending to be used as the first block in |
@0aveRyan, that sounds just fine to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this everyone, looks great and I agree let's focus on heading as depending on the issue, subheading may not be around long.
The current description for Heading blocks confusingly states that Headings are placed above the post or page contents, when they're used to describe document sections.