Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Heading Block description #9179

Merged
merged 4 commits into from
Aug 25, 2018
Merged

Update Heading Block description #9179

merged 4 commits into from
Aug 25, 2018

Conversation

0aveRyan
Copy link
Contributor

The current description for Heading blocks confusingly states that Headings are placed above the post or page contents, when they're used to describe document sections.

  • Headings divide the page contents, aren't placed above.
  • Headings may be used in CPTs -- direct reference to Post or Page should be removed.
  • Headings vs. Subheadings -- one is used for SEO weighting, one is simply formatted paragraph text... we don't want to get overly technical, but this distinct difference should be gently explained.

@0aveRyan 0aveRyan added [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Aug 20, 2018
@michelleweber
Copy link

Could you share screenshots of the things you think should be changed? And do you have proposed language (it's fine if you don't)? Thanks!

@0aveRyan
Copy link
Contributor Author

@michelleweber
This is the description that prompted this PR:
old-heading

These headings are used inside the page content to divide it, not above it.

This description is also not super clear:
old-subheading

Updated Heading description:
new-heading

Updated Subheading description:
new-subheading

@michelleweber
Copy link

Perfect, thanks. I'll offer tweaks that you can take or leave; your suggested changes are clear, but I'd love to bring the tone more in line with the other descriptions.

Heading: Help visitors (and search engines!) understand what they're reading with a short description.

I still like the subhead description, but if you want something more pointed:

Subheading: Add a subtitle above a section of your content to introduce your next topic and help readers follow the flow.

(Personally, I'm not sure the user needs to know at this point that the heading is used for SEO, I think they just need to know what happens when they insert this block. So my instinct would be either to save the space and remove that, or include it as a parenthetical to make it clear that it's supplemental info.)

@chrisvanpatten
Copy link
Contributor

One note about the subheading block is that it can only be used once (see #8140).

@0aveRyan
Copy link
Contributor Author

@chrisvanpatten yeah.. that's really not apparent, I think #8140 needs reopened. As indicated in that PR and in the audit in #8234 (which suggests killing it), it's super confusing when to use it.

Also, it seems strange that a Subheading is simply a <p> tag with a targetable classname. If it stays, there should be a way to set this to a true semantic heading tag, but that makes it all the more confusing.

I appreciate the value, I've built plenty of news sites with those subheading decks, but without a way to really explain itself easily and the nuance between it and say an <h3> it seems likely it would often be used incorrectly as the review indicated.

@chrisvanpatten
Copy link
Contributor

Also, it seems strange that a Subheading is simply a

tag with a targetable classname. If it stays, there should be a way to set this to a true semantic heading tag, but that makes it all the more confusing.

It's not semantically a heading though :)

But yes I agree about reopening #8140 and totally appreciate the confusing name.

@0aveRyan
Copy link
Contributor Author

0aveRyan commented Aug 21, 2018

Yes, the envisioned use isn't a semantic <hX> tag, but if left-in, making it a semantic heading seems only fair to the developers who would rightly assume a Subheading is a form of semantic heading.

As subtitle or deck it's much less confusing. It's totally reasonable to assume Subheading would refer to some form of <h2> - <h6>.

@0aveRyan 0aveRyan changed the title Update heading and subheading blocks descriptions Update Heading Block description Aug 21, 2018
@0aveRyan
Copy link
Contributor Author

0aveRyan commented Aug 21, 2018

For this PR, I've reverted changes to the Subheading block to make the correction to the Heading block only @michelleweber, however the new description doesn't really speak to section-ing the document and kinda sounds like an excerpt.

@ZebulanStanphill
Copy link
Member

Briefly describes the following section to visitors and search engines.

Help visitors (and search engines!) understand what they're reading with a short description.

I do not either of these descriptions work. It sounds like some kind of meta description. A heading is definitely not a short description of the content that follows. It is the title of a section of a document... or in other words, the heading of a section of a document.

How about something like this:

Use a heading to add a title to a section of content.

Or alternatively:

Add a title to a section of content with a heading.

Or how about this:

Use headings to divide your content into named sections.

@michelleweber
Copy link

Heading: Help visitors (and search engines!) understand what they're reading. Add headlines to introduce your topics and help readers follow the flow.

And for subhead, the original subhead text plus "Use it under a heading to add context." for more clarity.

@0aveRyan
Copy link
Contributor Author

0aveRyan commented Aug 21, 2018

@michelleweber thank you for your patience 😌 I think these are getting nicely refined.

If I may be a bit picky, Headings could be used to title Video/Embed blocks, Audio/Playlist blocks, etc, so I'm not sure about reading and readers. How do you feel about Introduce topics and help visitors (and search engines!) understand how your content is organized.?

edit-preview

I hesitate to update the Subheading in this PR if #8140 is being reopened as @chrisvanpatten indicated, so that can be a separate PR. As-coded, the block can only be inserted once, intending to be used as the first block in the_content, however can be inserted elsewhere and there's a plugin to allow infinite copies of it... I think as-named it's a bit confusing and the independent block audit suggested removing it. If it does stay, I think it's single-use limitation would need to be conveyed in the description.

@michelleweber
Copy link

@0aveRyan, that sounds just fine to me!

@0aveRyan 0aveRyan removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Aug 24, 2018
@0aveRyan 0aveRyan mentioned this pull request Aug 24, 2018
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this everyone, looks great and I agree let's focus on heading as depending on the issue, subheading may not be around long.

@karmatosed karmatosed merged commit 69ee079 into WordPress:master Aug 25, 2018
@0aveRyan 0aveRyan deleted the update/improve-heading-blocks-descriptions branch August 25, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants