Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color palette: make the Clear link consistent with buttons in other settings #8875

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Color palette: make the Clear link consistent with buttons in other settings #8875

merged 2 commits into from
Aug 23, 2018

Conversation

eliorivero
Copy link
Contributor

This PR updates the Clear link in the color palette to make it consistent with similar actionable elements found in other panels like the Reset buttons in Text Settings:

captura de pantalla 2018-08-11 a la s 13 38 17

or the Image Settings panel:

captura de pantalla 2018-08-11 a la s 13 38 10

Description

This PR converts the link into a small default button.

How has this been tested?

Tested manually

Screenshots

Before

captura de pantalla 2018-08-11 a la s 13 40 20

After

captura de pantalla 2018-08-11 a la s 13 40 04

Types of changes

Several attributes are set for the Button component so it's rendered as a small button.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@eliorivero
Color palette: solve inconsistency between the Clear link and buttons…
f27d71c 
… in other panels like the Reset buttons in Text or Image settings
@eliorivero eliorivero changed the title Color palette: solve inconsistency between the Clear link and buttons in other settings Color palette: mae the Clear link and buttons in other settings Aug 11, 2018
@eliorivero eliorivero changed the title Color palette: mae the Clear link and buttons in other settings Color palette: make the Clear link consistent with buttons in other settings Aug 11, 2018
@ajitbohra ajitbohra added the Needs Design Feedback Needs general design feedback. label Aug 13, 2018
@karmatosed karmatosed self-requested a review August 13, 2018 11:07
karmatosed
karmatosed approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this although I do still feel it could be a text link. With not minding it in mind let's add and see if people benefit from it.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Aug 13, 2018
@eliorivero
Copy link
Contributor Author

Thanks for the approval Tammie. I've updated the snapshot to reflect the changes introduced and now tests pass.

tofumatt
tofumatt approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaay this has always bothered me so much, thanks for making it a button ❤️

@tofumatt tofumatt merged commit 24b935f into WordPress:master Aug 23, 2018
@tofumatt tofumatt added this to the 3.7 milestone Aug 23, 2018
@eliorivero
Copy link
Contributor Author

Thanks to you @tofumatt for reviewing it!

@eliorivero eliorivero deleted the update/color-palette-buttons branch August 24, 2018 14:22
@mtias
Copy link
Member

mtias commented Aug 30, 2018

Nice, thanks for the update!

@Soean Soean mentioned this pull request Sep 11, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

@karmatosed karmatosed karmatosed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
5 participants
@eliorivero @mtias @tofumatt @karmatosed @ajitbohra