Repository navigation
Conversation
🤖 PR meta 🤖📦 Bundle sizeSize Change: 0 B Total Size: 9.05 MB
🏁 Flaky testsSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. Regression: updating a specific option will only change its value and will not corrupt others in
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add a migration guide from the legacy
@wordpress/componentsSelectControlto@wordpress/ui, attached to the legacy component's Storybook entry and linked from its recommendation notice.Why?
The recent migrations exposed differences beyond prop names, including empty-string defaults displaying a placeholder, missing initial selections, object callbacks, and portaled popup behavior. Consolidate the guidance from #84345, #84546, #84584, #83035, #84936, and #85172.
How?
Document value identity, callbacks and refs, labels and descriptions, trigger props, grouped native options, minimal controls, overlay integration, and test updates. Recommend one serialization pattern for preserving stored empty strings, distinguish clearable null values and placeholders, and explain form-submission implications. Embed interactive examples, including a controlled empty-string story that displays its stored value.
Testing Instructions
"sticky"to"", and reopening the popup retains Default. Repeat with the keyboard.Screenshots or screencast
The before images show the static examples at
949e94f4def1. The after images show the interactive examples added by this revision. Both use the same viewport and 2x device pixels. The minimal after image focuses on the interactive trigger.