Skip to content

Tests: Use strict assertions in navigation link variations tests #84888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lancewillett merged 2 commits into from
Oct 16, 2026
Merged

Tests: Use strict assertions in navigation link variations tests #84888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75a73c5
Tests: Use strict assertions in navigation link variations tests
shail-mehta Oct 16, 2026
304c5d9
Merge branch 'trunk' into tests/strict-assertions-navigation-link-var…
lancewillett Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpunit/blocks/block-navigation-link-variations-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public function test_navigation_link_variations_custom_post_type() {
$variation = $this->get_variation_by_name( 'custom_book', $variations );
$this->assertIsArray( $variation, 'Block variation does not exist' );
$this->assertArrayHasKey( 'title', $variation, 'Block variation has no title' );
$this->assertEquals( 'Custom Book', $variation['title'], 'Variation title is different than the post type label' );
$this->assertSame( 'Custom Book', $variation['title'], 'Variation title is different than the post type label' );
}

/**
Expand Down Expand Up @@ -145,7 +145,7 @@ public function test_navigation_link_variations_custom_taxonomy() {
$variation = $this->get_variation_by_name( 'book_type', $variations );
$this->assertIsArray( $variation, 'Block variation does not exist' );
$this->assertArrayHasKey( 'title', $variation, 'Block variation has no title' );
$this->assertEquals( 'Book Type', $variation['title'], 'Variation title is different than the post type label' );
$this->assertSame( 'Book Type', $variation['title'], 'Variation title is different than the post type label' );
}

/**
Expand Down
Loading