Skip to content

Tests: Use strict assertions in REST icons controller tests #84886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lancewillett merged 2 commits into from
Oct 16, 2026
Merged

Tests: Use strict assertions in REST icons controller tests #84886

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b6428d
Tests: Use strict assertions in REST icons controller tests
shail-mehta Oct 16, 2026
a1f8421
Merge branch 'trunk' into tests/strict-assertions-rest-icons-controller
lancewillett Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpunit/class-wp-rest-icon-controller-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public function test_get_items_search_includes_label() {
$data = $response->get_data();

$this->assertSame( 200, $response->get_status() );
$this->assertEquals( array( 'core/at-symbol' ), array_column( $data, 'name' ) );
$this->assertSame( array( 'core/at-symbol' ), array_column( $data, 'name' ) );
}

/**
Expand Down Expand Up @@ -242,7 +242,7 @@ public function test_get_items_search_includes_keywords() {
$data = $response->get_data();

$this->assertSame( 200, $response->get_status() );
$this->assertEquals( array( $icon_name ), array_column( $data, 'name' ) );
$this->assertSame( array( $icon_name ), array_column( $data, 'name' ) );
} finally {
wp_unregister_icon( $icon_name );
}
Expand Down
Loading