Repository navigation
Repair wp/5.9 branch Actions: Pin phpunit/phpunit to a PHP 5.6/7.0-compatible release - #84415
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84427
October 9, 2026 16:48
This was referenced Oct 9, 2026
desrosj
removed this pull request from stack #84427
October 10, 2026 00:16
desrosj
changed the base branch from
fix-actions-5.9/fix-setup-teardown-polyfills
to
wp/5.9
October 10, 2026 00:17
desrosj
force-pushed
the
fix-actions-5.9/fix-phpunit-dev-dependency-floor
branch
from
October 10, 2026 00:19
f3978cc to
6e42991
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/fix-setup-teardown-polyfills
October 10, 2026 00:21
desrosj
added this pull request to stack #84490
October 10, 2026 00:21
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 13, 2026 01:02
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Oct 15, 2026
desrosj
force-pushed
the
fix-actions-5.9/fix-phpunit-dev-dependency-floor
branch
from
October 19, 2026 17:09
6e42991 to
8970e53
Compare
desrosj
force-pushed
the
fix-actions-5.9/fix-phpunit-dev-dependency-floor
branch
from
October 21, 2026 15:43
8970e53 to
3d2accf
Compare
desrosj
removed this pull request from stack #84490
October 21, 2026 15:57
desrosj
added this pull request to stack #85300
October 21, 2026 15:58
desrosj
removed this pull request from stack #85300
October 21, 2026 19:47
desrosj
added this pull request to stack #85350
October 21, 2026 19:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82934.
What?
phpunit/phpunitdev dependency from^8.5to^5.7(resolves to5.7.27), so thePHP 5.6unit test jobs can load the plugin's Composer autoloader.config.platform.phpfrom8.1to5.6.20, and ignores five Composer advisories, so that version can resolve.composer.lockwithcomposer update phpunit/phpunit --with-all-dependencies.Why?
Both
PHP 5.6jobs fail before any test runs:wp-phpunit/wp-phpunitcallsclass_exists( 'PHPUnit\Runner\Version' ), which loads the class from the lockedphpunit/phpunit8.5.21. Its return type declarations don't parse on PHP 5.6. PHPUnit 5.7.27 has no namespacedPHPUnit\Runner\Version, so the check returnsfalseandwp-phpunitfalls back toPHPUnit_Runner_Version.wp/6.0makes the same change in #84281. This branch also needs:config.platform.php5.6.20: PHPUnit 5.7 requires PHP^5.6 || ^7.0, so it can't resolve against the8.1set in Repairwp/5.9branch Actions: Let the current Composer release install this branch's dependencies #84406.5.6.20is the matrix's lowest PHP version and Repairwp/5.9branch Actions: Let the current Composer release install this branch's dependencies #84406'srequire.phpfloor. With7.4, Composer would picksymfony/yamlandsymfony/polyfill-ctypereleases that need PHP 7.1+. The platform change can't go in Repairwp/5.9branch Actions: Let the current Composer release install this branch's dependencies #84406, because PHPUnit^8.5needs PHP 7.2+.PKSA-z3gr-8qht-p93vmatches everyphpunit/phpunitbelow 8.5.52, andPKSA-v5yj-8nmz-sk2q,PKSA-ft77-7h5f-p3r6,PKSA-b14r-zh1d-vdrcandPKSA-xz3r-9gp4-4m1zmatch everysymfony/yaml2.x–4.x, which PHPUnit 5.7 requires. The reasons recorded are the same as onwp/6.0.How?
Only
phpunit/phpunit's dependency tree changes incomposer.lock: 22 packages updated,phpunit/phpunit-mock-objects3.4.4 andsymfony/yamlv3.4.47 added, and fivephar-io/sebastian/theseerpackages removed.wp-phpunit/wp-phpunit5.9.17,yoast/phpunit-polyfills,composer/installersand the PHPCS packages keep their versions.The PHP 7.4, 8.0 and 8.1 jobs use the PHPUnit bundled in their Docker image, not the one in
vendor.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code