Repository navigation
Conversation
…ys use the workflow file from trunk, so this branch's copy never runs.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
wp/5.9 branch Actions: Remove obsolete/trunk-only workflowswp/5.9 branch Actions: Remove obsolete and trunk-only workflows
lucatume
left a comment
There was a problem hiding this comment.
Found some left-overs that could be removed.
| @@ -1,32 +0,0 @@ | |||
| name: Report Flaky Tests | |||
There was a problem hiding this comment.
With flaky-tests.yml removed, no workflow reads the flaky-tests-report artifact, so the step uploading it and the reporter producing it can go. These files aren't in the diff, so the changes can't be inline suggestions:
.github/workflows/end2end-test.yml, drop the upload step:
- - name: Archive flaky tests report
- uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2.2.2
- if: always()
- with:
- name: flaky-tests-report
- path: flaky-tests
- if-no-files-found: ignorepackages/e2e-tests/jest.config.js, drop the CI-only reporter that writes flaky-tests/*.json:
reporters: [
...baseConfig.reporters,
- // Report flaky tests results into artifacts for used in `report-flaky-tests` action.
- process.env.CI && '<rootDir>/config/flaky-tests-reporter.js',
].filter( Boolean ),and delete packages/e2e-tests/config/flaky-tests-reporter.js.
jest.retryTimes( 2 ) in packages/e2e-tests/config/setup-test-framework.js can stay: retries are useful on their own. Its comment would be stale, though:
// Retry failed tests at most 2 times in CI.
-// This enables `flaky-tests-reporter` and `report-flaky-tests` GitHub action
-// to mark test as flaky and automatically create a tracking issue about it.
if ( process.env.CI ) {
jest.retryTimes( 2 );
}There was a problem hiding this comment.
Thanks @lucatume, good catch.
Rather than changing this PR (which requires rebasing the 33 PRs above it), I've removed the leftovers in a new PR at the top of the stack, #85103. The same cleanup is at the top of the 7.0–6.0 stacks (#85104–#85114), where the reader was removed by this PR's equivalents or by the report-to-issues removal.
#85103 removes:
- The "Archive flaky tests report" upload step in
end2end-test.yml. - The
.github/report-flaky-testsaction, which nothing calls onceflaky-tests.ymlis gone. - The sentence in
testing-overview.mdsaying flaky tests are reported to issues.
I've left packages/e2e-tests/config/flaky-tests-reporter.js, its jest.config.js entry and the setup-test-framework.js comment as they are. They're part of the published @wordpress/e2e-tests package, and I'd rather not change a published package on a frozen branch for this. Without the upload step, the JSON files the reporter writes stay on the runner and are just discarded.
Let me know if you feel strongly about removing those and I can further consider the impact of the required e2e-tests package requiring a published update.
Part of #82934.
What?
Removes CI workflows on
wp/5.9that are either obsolete (React Native mobile testing), only maintained for the current WordPress release (performance testing), or that can never actually execute using this branch's own copy of the file.rnmobile-android-runner.ymlrnmobile-ios-runner.ymlif: falseand targeted the retiredmacos-11runnerperformance.ymlpull-request-automation.ymlpull_request_targetruns always use trunk's copy of the file, and itspush-triggered tasks return immediately outsidetrunk, so this branch's copy never does anythingstorybook-pages.ymlpush: branches: [trunk]only, and explicitly checks outref: trunk— this branch's copy never runs against its own contentupload-release-to-plugin-repo.ymlreleaseevent only; plugin releases are published fromtrunkandrelease/X.Y, never fromwp/5.9, so this branch's copy never runsstale-issue-add-needs-testing.yml,stale-issue-mark-stale.yml,stale-issue-needs-info.ymlscheduleonly; GitHub Actions always executesschedule-triggered workflows using the default branch's copy of the fileflaky-tests.ymlworkflow_runonly; GitHub Actions always executesworkflow_run-triggered workflows using the default branch's copy of the filebuild-plugin-zip.ymltrunkor arelease/*branch, so they never run fromwp/5.9scheduleandworkflow_runworkflows always run the copy of the file on the default branch (trunk), never this branch's copy.flaky-tests.yml's custom.github/report-flaky-testscomposite action, the step that uploads theflaky-tests-reportartifact, and the docs sentence about reporting are removed at the top of this stack, in #85103.Why?
Removing dead or unmaintained workflow files reduces confusion about what actually runs on this branch and removes CI resource usage/noise (in the RN case) that provides no real signal.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.