Skip to content

Repair wp/5.9 branch Actions: Remove obsolete and trunk-only workflows - #84395

Open
desrosj wants to merge 8 commits into
wp/5.9from
fix-actions-5.9/remove-rn-workflows
Open

desrosj wants to merge 8 commits into
wp/5.9from
fix-actions-5.9/remove-rn-workflows

Conversation

@desrosj

@desrosj desrosj commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Part of #82934.

What?

Removes CI workflows on wp/5.9 that are either obsolete (React Native mobile testing), only maintained for the current WordPress release (performance testing), or that can never actually execute using this branch's own copy of the file.

Workflow Purpose Reason removed
rnmobile-android-runner.yml React Native Android E2E tests React Native mobile support is no longer maintained or shipped as part of Gutenberg
rnmobile-ios-runner.yml React Native iOS E2E tests Same as above; job was already hardcoded if: false and targeted the retired macos-11 runner
performance.yml Performance tests Performance testing is only maintained on the branch for the current WordPress release
pull-request-automation.yml Assigns fixed issues and labels first-time contributors on new pull requests pull_request_target runs always use trunk's copy of the file, and its push-triggered tasks return immediately outside trunk, so this branch's copy never does anything
storybook-pages.yml Deploy Storybook to GitHub Pages push: branches: [trunk] only, and explicitly checks out ref: trunk — this branch's copy never runs against its own content
upload-release-to-plugin-repo.yml Publish releases to the WordPress.org plugin repo release event only; plugin releases are published from trunk and release/X.Y, never from wp/5.9, so this branch's copy never runs
stale-issue-add-needs-testing.yml, stale-issue-mark-stale.yml, stale-issue-needs-info.yml Issue-gardening automation schedule only; GitHub Actions always executes schedule-triggered workflows using the default branch's copy of the file
flaky-tests.yml Report flaky E2E tests as GitHub issues workflow_run only; GitHub Actions always executes workflow_run-triggered workflows using the default branch's copy of the file
build-plugin-zip.yml Builds the plugin zip, and holds the plugin release jobs (version bump, GitHub release) Nothing uses the zip it builds: WordPress 5.9 takes Gutenberg as npm packages. The release jobs only run when started from trunk or a release/* branch, so they never run from wp/5.9

schedule and workflow_run workflows always run the copy of the file on the default branch (trunk), never this branch's copy.

flaky-tests.yml's custom .github/report-flaky-tests composite action, the step that uploads the flaky-tests-report artifact, and the docs sentence about reporting are removed at the top of this stack, in #85103.

Why?

Removing dead or unmaintained workflow files reduces confusion about what actually runs on this branch and removes CI resource usage/noise (in the RN case) that provides no real signal.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 9, 2026
@desrosj desrosj self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 572b3187-9b9c-4334-a38e-0dd9ec0f6b6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@desrosj
desrosj removed this pull request from stack #84427 October 10, 2026 00:16
@desrosj
desrosj added this pull request to stack #84490 October 10, 2026 00:21
@desrosj
desrosj marked this pull request as ready for review October 13, 2026 00:56
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj changed the title Repair wp/5.9 branch Actions: Remove obsolete/trunk-only workflows Repair wp/5.9 branch Actions: Remove obsolete and trunk-only workflows Oct 16, 2026

@lucatume lucatume left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some left-overs that could be removed.

@@ -1,32 +0,0 @@
name: Report Flaky Tests

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With flaky-tests.yml removed, no workflow reads the flaky-tests-report artifact, so the step uploading it and the reporter producing it can go. These files aren't in the diff, so the changes can't be inline suggestions:

.github/workflows/end2end-test.yml, drop the upload step:

-            - name: Archive flaky tests report
-              uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2.2.2
-              if: always()
-              with:
-                  name: flaky-tests-report
-                  path: flaky-tests
-                  if-no-files-found: ignore

packages/e2e-tests/jest.config.js, drop the CI-only reporter that writes flaky-tests/*.json:

 	reporters: [
 		...baseConfig.reporters,
-		// Report flaky tests results into artifacts for used in `report-flaky-tests` action.
-		process.env.CI && '<rootDir>/config/flaky-tests-reporter.js',
 	].filter( Boolean ),

and delete packages/e2e-tests/config/flaky-tests-reporter.js.

jest.retryTimes( 2 ) in packages/e2e-tests/config/setup-test-framework.js can stay: retries are useful on their own. Its comment would be stale, though:

 // Retry failed tests at most 2 times in CI.
-// This enables `flaky-tests-reporter` and `report-flaky-tests` GitHub action
-// to mark test as flaky and automatically create a tracking issue about it.
 if ( process.env.CI ) {
 	jest.retryTimes( 2 );
 }

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucatume, good catch.

Rather than changing this PR (which requires rebasing the 33 PRs above it), I've removed the leftovers in a new PR at the top of the stack, #85103. The same cleanup is at the top of the 7.0–6.0 stacks (#85104–#85114), where the reader was removed by this PR's equivalents or by the report-to-issues removal.

#85103 removes:

  • The "Archive flaky tests report" upload step in end2end-test.yml.
  • The .github/report-flaky-tests action, which nothing calls once flaky-tests.yml is gone.
  • The sentence in testing-overview.md saying flaky tests are reported to issues.

I've left packages/e2e-tests/config/flaky-tests-reporter.js, its jest.config.js entry and the setup-test-framework.js comment as they are. They're part of the published @wordpress/e2e-tests package, and I'd rather not change a published package on a frozen branch for this. Without the upload step, the JSON files the reporter writes stay on the runner and are just discarded.

Let me know if you feel strongly about removing those and I can further consider the impact of the required e2e-tests package requiring a published update.

@desrosj
desrosj removed this pull request from stack #84490 October 21, 2026 15:57
@desrosj
desrosj added this pull request to stack #85300 October 21, 2026 15:58
@desrosj
desrosj removed this pull request from stack #85300 October 21, 2026 19:47
@desrosj
desrosj added this pull request to stack #85350 October 21, 2026 19:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants