Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
92e1805 to
22c52d9
Compare
…tor URL navigation e2e test.
22c52d9 to
f1cab71
Compare
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Part of #82931.
What?
Makes the "Redirection after template creation" test in
test/e2e/specs/site-editor/site-editor-url-navigation.spec.jswait for network activity to settle after opening the "Add New Template" dialog, before choosing "Single item: Post".Why?
When the dialog opens, the site editor asks the REST API whether any posts exist. Only once that answer arrives does "Single item: Post" lead to the "For a specific item" / "For all items" choice; before then, clicking it creates the generic
single-posttemplate straight away. The test could click before the answer arrived, so the choice never appeared and the test timed out waiting for "For a specific item". CI traces onwp/6.9andwp/6.8showed the click landing before that request finished in every failing attempt; this branch has the same test and the same dialog code (hasEntitiesis false until the request returns), so the fix is included for consistency.Upstream
Ports the wait added to this test by #73252 on
trunk, which reachedwp/7.0. Only the wait itself is ported; the rest of that PR is an unrelated feature change. Upstream'seslint-disable-next-line playwright/no-networkidlecomment is left out, because this branch'seslint-plugin-playwright(0.8.0) has no such rule and ESLint reports a disable comment for an unknown rule as an error.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code