Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #84239
October 8, 2026 03:30
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
October 8, 2026 14:45
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #84239
October 8, 2026 21:47
desrosj
changed the base branch from
fix-actions-6.2/fix-activate-theme-navigation-race
to
wp/6.2
October 8, 2026 21:48
desrosj
force-pushed
the
fix-actions-6.2/add-mariadb-version-option
branch
from
October 8, 2026 21:49
8d7b1c9 to
fd95069
Compare
desrosj
changed the base branch from
wp/6.2
to
fix-actions-6.2/fix-activate-theme-navigation-race
October 8, 2026 21:50
desrosj
added this pull request to stack #84355
October 8, 2026 21:50
desrosj
removed this pull request from stack #84355
October 10, 2026 00:03
desrosj
changed the base branch from
fix-actions-6.2/fix-activate-theme-navigation-race
to
wp/6.2
October 10, 2026 00:04
desrosj
force-pushed
the
fix-actions-6.2/add-mariadb-version-option
branch
from
October 10, 2026 00:05
fd95069 to
bcfa9fa
Compare
desrosj
changed the base branch from
wp/6.2
to
fix-actions-6.2/fix-activate-theme-navigation-race
October 10, 2026 00:07
desrosj
added this pull request to stack #84484
October 10, 2026 00:07
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
desrosj
removed this pull request from stack #84484
October 21, 2026 19:44
desrosj
added this pull request to stack #85344
October 21, 2026 19:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82931.
What?
Adds a
mariadbVersionoption to.wp-env.jsonand aWP_ENV_MARIADB_VERSIONenvironment variable, so the MariaDB versionwp-envuses can be chosen.env.development,env.tests), likephpVersion.WP_ENV_MARIADB_VERSIONoverrides both environments."lts","latest", or a numeric version such as"10.11"or"11.4.2". Anything else fails with a validation error, including an invalidWP_ENV_MARIADB_VERSIONvalue.mariadb, exactly as before. A set version becomesmariadb:<version>on themysqlandtests-mysqlservices.The README gets a table row and a "Specific MariaDB Version" section, and
packages/env/CHANGELOG.mdgets an entry under Unreleased.The README section also says:
wp-env destroy. It removes the environment's Docker containers, volumes, networks, and local files, not only the databases.mariadbVersionolder than 11.4,wp dbcommands in theclicontainers fail andwp-env cleanleaves the database as it is. The MariaDB client in the CLI image requires TLS whenphpVersionis unset or 8.1 or newer, and MariaDB servers before 11.4 do not offer it. WordPress itself is not affected.DOCKER_DEFAULT_PLATFORM=linux/amd64, which emulates every container in the environment, not only the database.Why?
This branch's
wp-env(5.11.2) always runs the floatingmariadbimage, which today is a MariaDB release many years newer than anything this branch was tested against. There is currently no way to pin an older, era-appropriate version for testing.How?
This follows #83751, which adds the same option and environment variable to
trunk. This branch'swp-envkeeps its configuration inpackages/env/lib/config/config.js, so the change follows howphpVersionworks there:validateConfig()checks the value (the newcheckMariaDBVersion()).parse-config.jspasses it through.config.jsadds the default and appliesWP_ENV_MARIADB_VERSION. UnlikeWP_ENV_PHP_VERSION, the new variable is validated.build-docker-compose-config.jssets each environment's image.New tests in
packages/env/lib/config/test/config.jscover the default, root and per-environment values, the environment-variable override, and both validation errors. New tests inpackages/env/test/build-docker-compose-config.jscover the image with and without a version. The config snapshot gains"mariadbVersion": null.With
"mariadbVersion": "10.11",wp-env start'swp db checkfails because the CLI image's client requires TLS; #84235, later in this stack, replaces that check with a health check.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.