Repository navigation
CI: Fix wp/6.9 CI ahead of the Node 24 port - #84171
Draft
manzoorwanijk wants to merge 7 commits into
Draft
manzoorwanijk wants to merge 7 commits into
manzoorwanijk wants to merge 7 commits into
Conversation
Ports trunk's `.github/setup-npm` action unchanged, ahead of the change that moves `wp/6.9` to Node 24 and npm 11.18 and uses it in its workflows. Landing it first keeps the Compressed Size check working on that change: `preactjs/compressed-size-action` checks out the base branch to build it, and the action's post step then needs `.github/setup-npm` to exist there.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Backport of #82478 to wp/6.9. Debian 11 bullseye reached end-of-life on 2026-08-31 and its packages left deb.debian.org, so building the PHP 7.4 and 8.0 WordPress images fails on `apt-get install`. Point the bullseye suite at archive.debian.org; the security suite is not there yet, so it is dropped.
The PHP jobs defaulted to `WordPress/WordPress`, the latest development version, so this release branch was tested against a newer core than the one it ships for and broke as core moved on (for example, the `wp-block-paragraph` class and deprecations added in WordPress 7.0). Pin the default to `WordPress/WordPress#6.9-branch`.
(cherry picked from commit a468930)
manzoorwanijk
changed the title
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
The report job checked out trunk and ran trunk's `packages/report-flaky-tests`, which now renders a PR comment and requires an `output-path` input this workflow does not pass. Every run with a flaky test failed "Report to GitHub" with "Input required and not supplied: output-path". Run the branch's action, whose inputs match.
manzoorwanijk
added
the
[Type] Build Tooling
manzoorwanijk
requested review from
Mamaduka,
adimoldovan,
aduth,
ciampo,
desrosj,
jsnajdr,
lancewillett and
tyxla
October 8, 2026 08:15
manzoorwanijk
marked this pull request as ready for review
October 8, 2026 08:15
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Oct 8, 2026
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix, CI is green and the changes look good to me. 🚀
I left a few small comments, but nothing blocking
| # Checkout defaults to using the branch which triggered the event, which | ||
| # isn't necessarily `trunk` (e.g. in the case of a merge). | ||
| # Use this branch's own report-flaky-tests: trunk's version takes | ||
| # different inputs and fails this workflow. |
Member
There was a problem hiding this comment.
Without ref: trunk, this job now checks out the PR code and runs npm ci, npm run build and report-flaky-tests from it, with a token that can write issues and PR comments. Before, only trunk code ran here. Could we use ref: wp/6.9 instead? That keeps the branch's own action, but doesn't run code from the PR.
| env: | ||
| WP_ENV_PHP_VERSION: ${{ matrix.php }} | ||
| WP_ENV_CORE: ${{ matrix.wordpress == '' && 'WordPress/WordPress' || format( 'https://wordpress.org/wordpress-{0}.zip', needs.compute-previous-wordpress-version.outputs.previous-wordpress-version ) }} | ||
| WP_ENV_CORE: ${{ matrix.wordpress == '' && 'WordPress/WordPress#6.9-branch' || format( 'https://wordpress.org/wordpress-{0}.zip', needs.compute-previous-wordpress-version.outputs.previous-wordpress-version ) }} |
Member
There was a problem hiding this comment.
The "latest" cell is pinned to 6.9 now, but the "previous major version" cell still reads the latest release from WordPress.org. Today that gives 7.0.x, so on wp/6.9 we test against 7.0 and not 6.8. Should we pin that one to 6.8 too?
| RUN sed -i 's|security.debian.org/debian-security buster/updates|archive.debian.org/debian-security buster/updates|g' /etc/apt/sources.list | ||
| RUN sed -i '/buster-updates/d' /etc/apt/sources.list | ||
|
|
||
| # bullseye (https://www.debian.org/News/2026/20260831) |
Member
There was a problem hiding this comment.
This changes the Dockerfile that @wordpress/env users get, and the package is published from this branch. Could be worth a CHANGELOG entry
| // Make sure the tests run in UTC timezone, regardless of the system timezone. | ||
| process.env.TZ = 'UTC'; | ||
| // Avoid time-based caniuse-lite warnings tripping jest-console assertions. | ||
| process.env.BROWSERSLIST_IGNORE_OLD_DATA = 'true'; |
Member
There was a problem hiding this comment.
BROWSERSLIST_IGNORE_OLD_DATA hides the warning, but the caniuse-lite data stays old. Would it be better to update caniuse-lite in the lockfile? If this is just a quick fix for the release branch, that's fine with me.
manzoorwanijk
marked this pull request as draft
October 8, 2026 12:16
The job derived the previous major from the newest WordPress release. With 7.1 out, it picked 7.0, a release newer than the branch, and the 6.8 coverage disappeared. Count back from the branch's own release instead.
wp/6.9's report-flaky-tests still opens and reopens `[Type] Flaky Test` issues and comments on pull requests, which trunk no longer does. Trunk's version takes different inputs and cannot run here, so drop the report job and the output only it read.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #82328, #72973
Gets
wp/6.9CI green ahead of #84162, which moves the branch to Node 24 and npm 11.18 and is stacked on this PR.Why?
CI on
wp/6.9is red before any port change, so every PR in the stack would fail. #84162 also needs.github/setup-npmon its base: Compressed Size builds the base branch, and the action's post step fails if the file is missing there.How?
WordPress/WordPress#6.9-branchinstead of the latest development version, which fails 22 tests.wp/7.0, so the Browserslist old data warning stops failing 10 JS unit tests..github/setup-npm, unused until Build: Move wp/6.9 to Node 24 and npm 11.18 with the npm v12 supply chain defaults #84162.Merge order: this PR, then #84162. Publishing
wp-6.9from trunk also needs #84160.Testing Instructions
CI passes on this PR and on #84162.
Use of AI Tools
Claude Code (Opus) prepared this PR; I reviewed it.