Skip to content

Notes: Fix flaky thread scroll e2e test - #84118

Merged
Mamaduka merged 1 commit into
trunkfrom
fix/notes-flaky-thread-scroll-test
Oct 6, 2026
Merged

Mamaduka merged 1 commit into
trunkfrom
fix/notes-flaky-thread-scroll-test

Conversation

@Mamaduka

@Mamaduka Mamaduka commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

What?

Noticed in #84101 and #84110

Adds spacer paragraphs below the noted block in the "scrolls the thread before the canvas" e2e test. The test was flaky on CI: its last assertion failed with Expected: > 221, Received: 221.

Why?

The post held only the noted paragraph, so the canvas could scroll at most 221px. After the replies were added, the canvas started anywhere from 204 to 221. When it started at 221, it was already at the bottom, so a wheel scroll past the end of the thread could not move it.

Testing Instructions

  1. Run npm run test:e2e -- test/e2e/specs/editor/various/block-notes-floating.spec.js -g "scrolls the thread before the canvas" --repeat-each=20 --retries=0.
  2. All runs pass.

Before the fix, 2 of 10 local Chromium runs failed at the canvas assertion. After the fix, 20 of 20 passed. The full block-notes-floating.spec.js suite passes (34 tests).

Use of AI Tools

Claude Code found the cause, wrote the fix and ran the tests. I reviewed the change.

@Mamaduka Mamaduka added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Oct 6, 2026
@Mamaduka Mamaduka self-assigned this Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

📦 Bundle size

Size Change: 0 B

Total Size: 8.29 MB

bded307 Run

@adamsilverstein adamsilverstein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@Mamaduka
Mamaduka merged commit 6058149 into trunk Oct 6, 2026
103 checks passed
@Mamaduka
Mamaduka deleted the fix/notes-flaky-thread-scroll-test branch October 6, 2026 13:23
@github-actions github-actions Bot added this to the Gutenberg 24.2 milestone Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants