Repository navigation
Notes: Fix flaky thread scroll e2e test - #84118
Merged
Merged
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 📦 Bundle sizeSize Change: 0 B Total Size: 8.29 MB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Noticed in #84101 and #84110
Adds spacer paragraphs below the noted block in the "scrolls the thread before the canvas" e2e test. The test was flaky on CI: its last assertion failed with
Expected: > 221, Received: 221.Why?
The post held only the noted paragraph, so the canvas could scroll at most 221px. After the replies were added, the canvas started anywhere from 204 to 221. When it started at 221, it was already at the bottom, so a wheel scroll past the end of the thread could not move it.
Testing Instructions
npm run test:e2e -- test/e2e/specs/editor/various/block-notes-floating.spec.js -g "scrolls the thread before the canvas" --repeat-each=20 --retries=0.Before the fix, 2 of 10 local Chromium runs failed at the canvas assertion. After the fix, 20 of 20 passed. The full
block-notes-floating.spec.jssuite passes (34 tests).Use of AI Tools
Claude Code found the cause, wrote the fix and ran the tests. I reviewed the change.