Skip to content

Breadcrumb: fix getMeasurementRender for React 19 #84069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 1 commit into from
Oct 6, 2026
+3 −2
Merged

Breadcrumb: fix getMeasurementRender for React 19 #84069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

### Bug Fixes

- `Breadcrumb`: Keep a custom renderer's ref on the visible item ([#84069](https://github.com/WordPress/gutenberg/pull/84069)).
- `RadioGroup`: Preserve value type inference in callbacks. `RadioGroupControl`: Type selected values and callbacks as strings to match its items ([#83872](https://github.com/WordPress/gutenberg/pull/83872)).
- `Menu`: Align the first submenu item's label with its parent label while preserving item centering, including when their heights differ ([#84031](https://github.com/WordPress/gutenberg/pull/84031)).
- `Checkbox`: Prevent rounded themes from making checkboxes circular. ([#83526](https://github.com/WordPress/gutenberg/pull/83526))
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/breadcrumb/measurement-render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const EVENT_HANDLER_PATTERN = /^on[A-Z]/;
function isBehaviorProp( propName: string ) {
return (
propName === 'id' ||
propName === 'ref' ||
propName === 'tabIndex' ||
EVENT_HANDLER_PATTERN.test( propName )
);
Expand All @@ -15,7 +14,8 @@ function isBehaviorProp( propName: string ) {
function getMeasurementProps( props: Record< string, unknown > ) {
return Object.fromEntries(
Object.entries( props ).filter(
( [ propName ] ) => ! isBehaviorProp( propName )
( [ propName ] ) =>
! isBehaviorProp( propName ) && propName !== 'ref'
)
);
}
Expand Down
Loading