Repository navigation
Repair wp/6.7 branch Actions: Fix flaky Openverse image drag-and-drop e2e test - #84041
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #83418
October 2, 2026 19:59
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-openverse-image-drag-and-drop-test
branch
from
October 5, 2026 12:55
f22453f to
d844308
Compare
desrosj
marked this pull request as ready for review
October 5, 2026 19:06
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-openverse-image-drag-and-drop-test
branch
from
October 5, 2026 20:43
d844308 to
d5324be
Compare
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-openverse-image-drag-and-drop-test
branch
from
October 5, 2026 20:50
d5324be to
8492a71
Compare
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-openverse-image-drag-and-drop-test
branch
from
October 7, 2026 14:18
8492a71 to
0fa6851
Compare
desrosj
removed this pull request from stack #83418
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.7/replace-db-check-with-healthcheck
to
wp/6.7
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-openverse-image-drag-and-drop-test
branch
from
October 7, 2026 18:15
0fa6851 to
cc07b40
Compare
github-actions
Bot
added
[Tool] E2E Test Utils
desrosj
changed the base branch from
wp/6.7
to
fix-actions-6.7/replace-db-check-with-healthcheck
October 7, 2026 18:18
desrosj
added this pull request to stack #84188
October 7, 2026 18:18
desrosj
removed this pull request from stack #84188
October 8, 2026 21:24
desrosj
changed the base branch from
fix-actions-6.7/replace-db-check-with-healthcheck
to
wp/6.7
October 8, 2026 21:25
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-openverse-image-drag-and-drop-test
branch
from
October 8, 2026 21:25
cc07b40 to
7990089
Compare
desrosj
changed the base branch from
wp/6.7
to
fix-actions-6.7/replace-db-check-with-healthcheck
October 8, 2026 21:27
desrosj
added this pull request to stack #84350
October 8, 2026 21:27
github-actions
Bot
removed
[Tool] E2E Test Utils
desrosj
removed this pull request from stack #84350
October 9, 2026 23:40
desrosj
changed the base branch from
fix-actions-6.7/replace-db-check-with-healthcheck
to
wp/6.7
October 9, 2026 23:41
desrosj
force-pushed
the
fix-actions-6.7/fix-flaky-openverse-image-drag-and-drop-test
branch
from
October 9, 2026 23:42
7990089 to
8b8d941
Compare
desrosj
changed the base branch from
wp/6.7
to
fix-actions-6.7/replace-db-check-with-healthcheck
October 9, 2026 23:44
desrosj
added this pull request to stack #84474
October 9, 2026 23:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82783.
What?
Mocks Openverse in
test/e2e/specs/editor/blocks/image.spec.js's "can be replaced by dragging-and-dropping images from the inserter" test.page.route()answers the search request toapi.openverse.orgwith two results on a fakeopenverse.testhost, and serves those two images fromtest/e2e/assets.Why?
The test dragged real Openverse search results onto an image block. When a result is dropped, the editor downloads the full-size image with
fetch()and uploads it to the media library. The first result is currently a NASA image hosted onlive.staticflickr.com, and on GitHub-hosted runners that download can fail withnet::ERR_FAILED(the same URL loads outside CI). Nothing is uploaded, and the image block stays empty.On this branch it failed
Playwright - 1on #83835 at 04:17 UTC on 2026-09-30, then passed on #83864 at 10:32 UTC the same day. The same failure broke the test ontrunk, which #83842 fixed. Mocking the search and the images removes the test's dependency on both services.How?
Ports #83842 from
trunk, with one change: the first mocked image is1024x768_e2e_test_image_size.jpeginstead of the 10×1010x10_e2e_test_image_green.png, which this branch doesn't have.On this branch, opening the inserter's Media tab zooms the canvas out (from 6.8 that only happens when there's a section root). With a 10×10 first image, the zoomed-out image block is only a few pixels tall, and its center sits under the in-between inserter's "Add pattern" button, so the second drag can't drop:
locator.dragTotimes out because the button intercepts pointer events. A large first image keeps the block tall, as the real Openverse photos did. Locally on this branch, the test with trunk's images failed 3 of 3 runs, and with this change passed 5 of 5.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code