Skip to content

SandBox: Fix embed previews that require a referrer in Safari #84014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 6 commits into from
Oct 7, 2026
Merged

SandBox: Fix embed previews that require a referrer in Safari #84014

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de4a1a1
SandBox: Fix YouTube embed previews failing in Safari
Mustafabharmal Oct 2, 2026
3e3b2ac
Update SandBox changelog reference
Mustafabharmal Oct 2, 2026
3529686
Merge branch 'trunk' into fix/73288-youtube-embed-safari-referrer
Mustafabharmal Oct 6, 2026
ef0b3c6
Tests: Cover the embed preview referrer in WebKit
Mustafabharmal Oct 6, 2026
147f035
Merge branch 'trunk' into fix/73288-youtube-embed-safari-referrer
Mustafabharmal Oct 6, 2026
aa05db3
Merge branch 'trunk' into fix/73288-youtube-embed-safari-referrer
t-hamano Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
- `BorderControl`, `BorderBoxControl`: Stop offering `%` as a width unit, since `border-width` does not accept percentages. A width already set in `%` keeps showing its unit ([#83492](https://github.com/WordPress/gutenberg/pull/83492)).
- `UnitControl`: After clearing a value whose unit is not in `units`, give the next typed value the unit shown in the select instead of the cleared one ([#83492](https://github.com/WordPress/gutenberg/pull/83492)).
- `ResizableBox`: Update `re-resizable` to `6.11.2`, which supports React 18 and renders the top and left handles before the content so focus order matches visual order ([#83754](https://github.com/WordPress/gutenberg/pull/83754)).
- `SandBox`: Send the page URL as the referrer from iframes inside `allowSameOrigin` sandboxes in Safari, fixing embed previews that require a referrer, such as YouTube's "Error 153" ([#84014](https://github.com/WordPress/gutenberg/pull/84014)).
- `PaletteEdit`: Keep an item's slug when it is renamed, so blocks and styles that reference the preset keep working ([#83750](https://github.com/WordPress/gutenberg/pull/83750)).

### Internal
Expand Down
11 changes: 11 additions & 0 deletions packages/components/src/sandbox/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,17 @@ function SameOriginSandBox( {
// was loaded over the network, so DOM creation and mutation, script
// execution, etc. all work as expected.
contentDocument.open();
// Nested iframes should send this page's URL as their `Referer`, which
// YouTube requires. Safari sends none after `open()` until the URL is
// set again with `replaceState()`. Firefox throws here but already
// sends the referrer. See https://bugs.webkit.org/show_bug.cgi?id=169846.
try {
contentDocument.defaultView?.history.replaceState(
null,
'',
window.location.href
);
} catch {}
contentDocument.write(
buildSandBoxDocument( {
html,
Expand Down
Loading