Repository navigation
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the 📦 Bundle sizeSize Change: +478 B (+0.01%) Total Size: 8.25 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. should select an inline image by clicking it @WebKit @Firefox in
|
87e7f12 to
e32fb79
Compare
|
What if we just show the inspector for all blocks and no block toolbar for all blocks to avoid the extra flag and the differentiation between text blocks or not? Maybe the consistency can help the users no? |
|
You mean removing the block alignment from all blocks? If yes, then I'm very hesitant. Block toolbar curation also suggests making images wide and full-wide is a common use case. I wonder on the justification tools angle if there's something in the layout property on the parent we can use? Probably not since we're mixing flow here. |
|
If block alignment is important and we want to keep in the toolbar, maybe we need to rethink the toolbar. I don't think targeting specific blocks solve anything personally when it comes to block size, other blocks will also have the same issues. |
|
Based on the feedback, closing this one alongside #83945. Thanks all, for looking. |
What?
Alternative to #83945. Based on discussion there, and in Slack.
What this PR does:
Why?
There's a long story to this. It starts with the suggestion that the block toolbar is a curation mechanism, a place where the most important actions are contextually available, right there. But while also deliberately omitting others, that are perhaps not as important to a particular flow. Making a full-wide paragraph, for example, can be argued as needing to be possible, but it is also easy to argue that it should not be a primary or common interaction.
The inspector on the other hand is a good home for more advanced interactions, and is therefore a good home for it. The Layout panel already features justification options. It's a way to make the actions available, while managing their footprint and curation.
And in fact in developing this PR it became clear that managing that footprint is even more important. Consider the screenshot above, it shows a wide paragraph inside a Group. But the paragraph is not wide, it's bounded by the limited width of the group. There's no visual indication that anything is wide, so it's arguably misleading. And yet it's accurate: if you expanded the width of the group, the paragraph would expand with it, until reaching its bounded width. So it's intended, and immensely confusing.
That same confusion is documented in wp.com support sessions too, issues that I've previously tried to fix in these PRs:
#79285 is related.
All of those are meant to mitigate confusion around someone setting a block to being wide or fullwide, and not seeing any result at all.
Testing Instructions
Use of AI Tools
Opus 5, and my bot has a couple of notes it would like to surface as open questions: