Repository navigation
Base Styles: Default the admin theme color to Blueberry #83749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mirka
merged 6 commits into
WordPress:trunk
from
adamwoodnz:update/base-styles-default-admin-color
Sep 30, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
45f6277
Base Styles: Default the admin theme color to #3858e9
adamwoodnz dda8f99
Base Styles: Link the changelog entry to its PR
adamwoodnz 47b8f22
Base Styles: Keep the Fresh admin scheme on #007cba
adamwoodnz d3e2b76
Use #3858e9 as the admin theme color fallback
adamwoodnz ed9b271
Base Styles: Ship the Fresh rule with the default properties
adamwoodnz dbdc09d
Merge trunk into update/base-styles-default-admin-color
mirka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also include the
body.admin-color-freshrule in this stylesheet (with a comment explaining why)?The addition to
wordpress-admin-schemes()preserves Fresh when both stylesheets update together, as they do when installing this Gutenberg PR. But plugins can compiledefault-custom-propertiesinto their own CSS while relying on WordPress to supply the admin-scheme stylesheet. For example, EditorsKit imports these defaults in its Styles Manager styles, and WooCommerce imports them in its shared build styles.If such a plugin rebuilds with the updated base-styles package, its CSS gets the Blueberry root default, but the installed WordPress version may still supply a scheme stylesheet without the new Fresh rule. Fresh previously inherited the old blue from
:root, so it now inherits Blueberry instead. Plugins using only WordPress-provided styles would not have this mixed-version issue.I reproduced that color change in an isolated browser check using the compiled defaults alongside WordPress 6.9 and 7.0's shipped CSS. Including
body.admin-color-fresh { @include mixins.admin-scheme(#007cba); }here restored the original color.Keeping the Fresh rule in both places would make the protection travel with independently bundled defaults, while standalone apps without the Fresh body class still get Blueberry.
I think this is necessary to keep this PR in "enhancement" territory and not a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks. Added in 4873971:
body.admin-color-fresh { @include mixins.admin-scheme(#007cba); }now follows the:rootblock in_default-custom-properties.scss, with a comment on why. The rule stays inwordpress-admin-schemes()too, and the changelog entry covers both.Verified in wp-env with the Fresh scheme on the Dashboard. I removed the Fresh rule from
wp-base-stylesin the page to simulate an older WordPressadmin-schemes.css. The primary button staysrgb(0, 124, 186), because the rule now also ships in thecommands,block-editor,patterns, andeditorstylesheets. When I also removed those copies, it turnedrgb(56, 88, 233). The editor with Fresh is also#007cba.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I'm unable to re-run the failing CI checks, which I believe are unrelated. Would you be able to do that for me please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two separate CI issues were fixed on trunk, so I merged them in 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!