Repository navigation
Repair wp/7.0 branch Actions: Reset preferences after navigable toolbar e2e tests - #83721
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
|
Size Change: 0 B Total Size: 7.61 MB ℹ️ View Unchanged
|
desrosj
marked this pull request as ready for review
September 28, 2026 23:12
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
desrosj
force-pushed
the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
2 times, most recently
from
October 7, 2026 15:58
aa08cf6 to
ea86be6
Compare
desrosj
changed the base branch from
fix-actions-7.0/remove-install-nvm-step
to
wp/7.0
October 7, 2026 18:14
desrosj
force-pushed
the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
from
October 7, 2026 18:16
ea86be6 to
02af287
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/fix-flaky-router-navigate-test
October 7, 2026 18:17
desrosj
changed the base branch from
fix-actions-7.0/fix-flaky-router-navigate-test
to
wp/7.0
October 8, 2026 21:11
desrosj
force-pushed
the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
from
October 8, 2026 21:12
02af287 to
83ac08f
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/fix-flaky-router-navigate-test
October 8, 2026 21:13
desrosj
changed the base branch from
fix-actions-7.0/fix-flaky-router-navigate-test
to
wp/7.0
October 9, 2026 23:28
desrosj
force-pushed
the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
from
October 9, 2026 23:28
83ac08f to
93e7778
Compare
desrosj
changed the base branch from
wp/7.0
to
fix-actions-7.0/fix-flaky-router-navigate-test
October 9, 2026 23:30
desrosj
force-pushed
the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
from
October 19, 2026 17:04
93e7778 to
aa0ddbc
Compare
ntsekouras
approved these changes
Oct 23, 2026
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Same as trunk's #78115, and Playwright 4 goes green here.
desrosj
force-pushed
the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
from
October 23, 2026 17:27
aa0ddbc to
aa6c423
Compare
desrosj
force-pushed
the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
from
October 26, 2026 17:58
aa6c423 to
96cd269
Compare
desrosj
added
the
props-bot
github-actions
Bot
removed
the
props-bot
desrosj
deleted the
fix-actions-7.0/reset-preferences-after-navigable-toolbar-tests
branch
October 27, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82782.
What?
Resets preferences through the REST API after every test in
test/e2e/specs/editor/various/navigable-toolbar.spec.js, instead of turning the fixed ("Top") toolbar back off at the end of two of its tests.Why?
The "Block toolbar will scroll to reveal hidden buttons with fixed toolbar" test turns the fixed toolbar on and, as its last step, off again. Preferences are saved to the server with a 2.5-second debounce, so when the test finishes quickly the page closes before the "off" is saved, and the server keeps
fixedToolbar: true. Every later post-editor test in the same shard then loads with the top toolbar on: the floating block toolbar and the editor top bar's "Back"/"Options" buttons aren't where those tests expect them, so they fail on every retry. On this stack,navigable-toolbar.spec.js:188/:256andpatterns.spec.js:791/:1064failed together in at least 10 earlier runs.requestUtils.resetPreferences()writes the preferences directly over REST from the test runner, so it doesn't depend on the page staying open, and it also runs after a failed test.Upstream
A straight cherry-pick of
2e877e9(#78115) fromtrunk.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code