Skip to content

UI: Add change actions to form primitive stories #83591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 3 commits into from
Sep 29, 2026
Merged

UI: Add change actions to form primitive stories #83591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f48facd
UI: Add change actions to form primitive stories
mirka Sep 28, 2026
cce84f9
UI: Forward change actions in controlled primitive stories
mirka Sep 29, 2026
d5f8242
Merge branch 'trunk' into add-form-story-change-actions
mirka Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/autocomplete/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ const meta: Meta< typeof Autocomplete.Root > = {
'Autocomplete.Status': Autocomplete.Status,
'Autocomplete.Clear': Autocomplete.Clear,
},
argTypes: {
onValueChange: { action: 'onValueChange' },
},
parameters: {
componentStatus: {
status: 'recommended',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/checkbox-group/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const meta: Meta< typeof CheckboxGroup > = {
subcomponents: {
'CheckboxGroup.NestedItems': CheckboxGroup.NestedItems,
},
argTypes: {
onValueChange: { action: 'onValueChange' },

@ciampo ciampo Sep 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't fire in WithParentCheckbox because that story ignores args and passes setFruitValue as its change handler. We should forward args.onValueChange after updating state?

Same for the controlled Autocomplete and Combobox examples

},
parameters: {
componentStatus: {
status: 'use-with-caution',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/checkbox/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ const meta: Meta< typeof Checkbox > = {
title: 'Components/@wordpress-ui/Form/Primitives/Checkbox',
id: 'design-system-components-form-primitives-checkbox',
component: Checkbox,
argTypes: {
onCheckedChange: { action: 'onCheckedChange' },
},
parameters: {
componentStatus: {
status: 'use-with-caution',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/combobox/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ const meta: Meta< typeof Combobox.Root > = {
'Combobox.Status': Combobox.Status,
'Combobox.Clear': Combobox.Clear,
},
argTypes: {
onValueChange: { action: 'onValueChange' },
},
parameters: {
componentStatus: {
status: 'use-with-caution',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/radio-group/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ const meta: Meta< typeof RadioGroup > = {
title: 'Components/@wordpress-ui/Form/Primitives/RadioGroup',
id: 'design-system-components-form-primitives-radiogroup',
component: RadioGroup,
argTypes: {
onValueChange: { action: 'onValueChange' },
},
parameters: {
componentStatus: {
status: 'use-with-caution',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/select/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ const meta: Meta< typeof Select.Root > = {
'Select.ItemLabel': Select.ItemLabel,
'Select.ItemDescription': Select.ItemDescription,
},
argTypes: {
onValueChange: { action: 'onValueChange' },
},
parameters: {
componentStatus: {
status: 'recommended',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/switch/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ const meta: Meta< typeof Switch > = {
title: 'Components/@wordpress-ui/Form/Primitives/Switch',
id: 'design-system-components-form-primitives-switch',
component: Switch,
argTypes: {
onCheckedChange: { action: 'onCheckedChange' },
},
parameters: {
componentStatus: {
status: 'use-with-caution',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/form/primitives/textarea/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ const meta: Meta< typeof Textarea > = {
title: 'Components/@wordpress-ui/Form/Primitives/Textarea',
id: 'design-system-components-form-primitives-textarea',
component: Textarea,
argTypes: {
onValueChange: { action: 'onValueChange' },
},
parameters: {
componentStatus: {
status: 'recommended',
Expand Down
Loading