Repository navigation
Repair wp/6.6 branch Actions: Improve reliability of TinyMCE-related tests - #83465
Open
desrosj wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
added this pull request to stack #83415
September 23, 2026 21:50
|
Size Change: 0 B Total Size: 1.73 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
September 25, 2026 01:43
9b6ad45 to
7cee0aa
Compare
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
September 25, 2026 02:14
7cee0aa to
d0c07ef
Compare
desrosj
removed this pull request from stack #83415
September 28, 2026 15:25
desrosj
changed the base branch from
fix-actions-6.6/stabilize-site-editor-tests
to
wp/6.6
September 28, 2026 15:25
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
September 28, 2026 15:27
desrosj
added this pull request to stack #83628
September 28, 2026 15:27
desrosj
marked this pull request as ready for review
September 28, 2026 15:57
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #83628
September 28, 2026 17:57
desrosj
changed the base branch from
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
to
wp/6.6
September 28, 2026 17:58
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
September 28, 2026 17:58
d0c07ef to
3db9543
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
September 28, 2026 17:59
desrosj
added this pull request to stack #83644
September 28, 2026 17:59
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
October 7, 2026 14:18
3db9543 to
debc1ce
Compare
github-actions
Bot
removed
[Tool] WP Scripts
desrosj
removed this pull request from stack #83644
October 7, 2026 18:12
desrosj
changed the base branch from
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
to
wp/6.6
October 7, 2026 18:13
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
October 7, 2026 18:15
debc1ce to
4ab2373
Compare
github-actions
Bot
added
[Tool] WP Scripts
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
October 7, 2026 18:17
desrosj
added this pull request to stack #84184
October 7, 2026 18:17
desrosj
removed this pull request from stack #84184
October 8, 2026 18:41
desrosj
changed the base branch from
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
to
wp/6.6
October 8, 2026 18:42
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
October 8, 2026 18:43
4ab2373 to
801a63a
Compare
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
October 8, 2026 18:45
desrosj
added this pull request to stack #84339
October 8, 2026 18:46
desrosj
removed this pull request from stack #84339
October 8, 2026 21:28
desrosj
changed the base branch from
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
to
wp/6.6
October 8, 2026 21:29
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
October 8, 2026 21:30
801a63a to
4c5d414
Compare
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
October 8, 2026 21:31
desrosj
added this pull request to stack #84351
October 8, 2026 21:32
github-actions
Bot
removed
[Tool] WP Scripts
desrosj
removed this pull request from stack #84351
October 9, 2026 23:44
desrosj
changed the base branch from
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
to
wp/6.6
October 9, 2026 23:45
desrosj
force-pushed
the
fix-actions-6.6/fix-flaky-metabox-tinymce-init-race
branch
from
October 9, 2026 23:46
4c5d414 to
b1a07ca
Compare
desrosj
changed the base branch from
wp/6.6
to
fix-actions-6.6/fix-flaky-dataviews-list-keyboard-tests
October 9, 2026 23:48
desrosj
added this pull request to stack #84476
October 9, 2026 23:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces the meta box E2E test's iframe-presence wait with a wait on TinyMCE's own
initializedflag, and adds the same wait after switching back to Visual mode. No change to what the test asserts.Why?
test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.jsswitches the meta box's TinyMCE instance out of Visual mode and types into the textarea. It guarded that switch with:That waits for the editor iframe element to be attached, which happens early in TinyMCE's startup — not at the end of it. The comment above it already claimed the intent was to wait "for it to initialize"; this makes the code actually do that.
When the mode switch lands inside that window, two things can go wrong: TinyMCE flips the editor back to Visual once initialization completes, discarding the typed text, and
getSelection()can return null while TinyMCE restores the cursor position. Both surface as intermittent failures inend2end-test.yml.Waiting on
window.tinyMCE.get( 'test_tinymce_id' ).initializedcloses the window, because that flag is set only after startup finishes. The bundled TinyMCE is 4.9.11 on every WordPress version these branches pin, and it defineswindow.tinyMCE, returns the instance fromEditorManager.get( id ), and sets.initializedon it.This is a straight port of
631bcb2(#78631) fromtrunk. The mode-switch button name is branch-specific — WordPress renamed that tab fromTexttoCodein WordPress 6.8, and this branch pins its test WordPress accordingly — so the selector is deliberately left alone.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code