Repository navigation
Conversation
The `.wp-env.json` file pins Core as `WordPress/WordPress#7.0-branch`, so every other test suite on this branch runs against WordPress 7.0. The performance tests do not: `bin/plugin/cli.js perf` builds its own, separate `.wp-env.json` for each branch it measures, and that file's `core` field is only pinned when an explicit `--wp-version` argument is passed on the command line. The `pull_request` step never passed one, so it silently fell back to `WordPress/WordPress` — WordPress Core's own development trunk, which moves continuously. Measuring a frozen plugin snapshot against a moving Core install makes the results meaningless at best, and breaks the suite outright once Core's architecture drifts far enough from what this branch's editor expects. Passing `--wp-version "7.0"` resolves to `https://wordpress.org/wordpress-7.0.zip`, giving the performance tests the same Core pin every other suite on this branch already uses. The `release`, `push`, and `workflow_dispatch` steps in this workflow already pass `--wp-version`; only the `pull_request` step was missing it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtSAAJkQ9P6vPtDumqStg8
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
desrosj
deleted the
fix-actions-7.0/pin-wp-version-performance-testing
branch
September 18, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82782.
What?
This pins WordPress 7.0 as the version to use when running the performance tests on
pull_requestevents.Why?
While this branch's
.wp-env.jsonpins Core asWordPress/WordPress#7.0-branch, the performance testing workflow never reads that file.bin/plugin/cli.js perfbuilds its own, separate.wp-env.jsonfor each branch it measures, and that file'scorefield is only pinned when an explicit--wp-versionargument is passed:With no
--wp-version,wpZipUrlstaysnulland the environment falls back toWordPress/WordPress— WordPress Core's own development trunk. The CLI even says so out loud, loggingUsing: WordPress trunkinstead ofUsing: WordPress v7.0.That means the
pull_requestjob was measuring this branch's frozen Gutenberg snapshot against a continuously moving Core install, ignoring the branch's own Core pin entirely. That makes the numbers meaningless at best, and breaks the suite outright once Core's architecture drifts far enough from what this branch's editor expects.--wp-version "7.0"resolves tohttps://wordpress.org/wordpress-7.0.zip(confirmed available), giving the performance tests the same Core pin every other test suite on this branch already uses.This workflow's
release,push, andworkflow_dispatchsteps already pass--wp-version; thepull_requeststep was the only one missing it. Nothing else about the step changes — its name and its"$GITHUB_BASE_REF"argument are already correct on this branch.The equivalent fix has already been made for
wp/6.5(#83005),wp/6.6(#82979), andwp/6.7(#82978).Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code