Skip to content

Storybook: Remove obsolete manifest extractor render workaround #83124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 1 commit into from
Sep 18, 2026
Merged

Storybook: Remove obsolete manifest extractor render workaround #83124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/ui/src/form/primitives/fieldset/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ const meta: Meta< typeof Fieldset.Root > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/Primitives/Fieldset',
component: Fieldset.Root,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <Fieldset.Root { ...args } />,
subcomponents: {
'Fieldset.Legend': Fieldset.Legend,
'Fieldset.Description': Fieldset.Description,
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/primitives/input-layout/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@ const meta: Meta< typeof InputLayout > = {
subcomponents: {
'InputLayout.Slot': InputLayout.Slot,
},
// Temporary: Due to an upstream bug, render the component explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <InputLayout { ...args } />,
parameters: {
componentStatus: {
status: 'recommended',
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/primitives/input/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ const meta: Meta< typeof Input > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/Primitives/Input',
component: Input,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <Input { ...args } />,
argTypes: {
defaultValue: { control: false },
onValueChange: { action: 'onValueChange' },
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/primitives/searchable-chip-select/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ const meta: Meta< typeof SearchableChipSelect > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/Primitives/SearchableChipSelect',
component: SearchableChipSelect,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <SearchableChipSelect { ...args } />,
subcomponents: {
'SearchableChipSelect.Group': SearchableChipSelect.Group,
'SearchableChipSelect.GroupLabel': SearchableChipSelect.GroupLabel,
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/primitives/select/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const meta: Meta< typeof Select.Root > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/Primitives/Select',
component: Select.Root,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <Select.Root { ...args } />,
subcomponents: {
'Select.Trigger': Select.Trigger,
'Select.Portal': Select.Portal,
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/primitives/textarea/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const meta: Meta< typeof Textarea > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/Primitives/Textarea',
component: Textarea,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <Textarea { ...args } />,
parameters: {
componentStatus: {
status: 'recommended',
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/primitives/validity-indicator/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const meta: Meta< typeof ValidityIndicator > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/Primitives/ValidityIndicator',
component: ValidityIndicator,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <ValidityIndicator { ...args } />,
parameters: {
componentStatus: {
status: 'recommended',
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/searchable-chip-select-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ const meta: Meta< typeof SearchableChipSelectControl > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/SearchableChipSelectControl',
component: SearchableChipSelectControl,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <SearchableChipSelectControl { ...args } />,
subcomponents: {
'SearchableChipSelectControl.Group': SearchableChipSelectControl.Group,
'SearchableChipSelectControl.GroupLabel':
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/select-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ const meta: Meta< typeof SelectControl > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/SelectControl',
component: SelectControl,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <SelectControl { ...args } />,
subcomponents: {
'SelectControl.Group': SelectControl.Group,
'SelectControl.GroupLabel': SelectControl.GroupLabel,
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/form/textarea-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ const meta: Meta< typeof TextareaControl > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Form/TextareaControl',
component: TextareaControl,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <TextareaControl { ...args } />,
argTypes: {
defaultValue: { control: false },
onValueChange: { action: 'onValueChange' },
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/spinner/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const meta: Meta< typeof Spinner > = {
tags: [ 'manifest' ],
title: 'Design System/Components/Spinner',
component: Spinner,
// Temporary: Due to an upstream bug, render the root explicitly so the
// components manifest extractor can resolve props from the JSX.
//
// See: https://github.com/storybookjs/storybook/issues/34877
render: ( args ) => <Spinner { ...args } />,
parameters: {
componentStatus: {
status: 'recommended',
Expand Down
Loading