Remove jQuery dependency from @wordpress/api-fetch

[mmtr]

This removes the jQuery dependency from the @wordpress/api-fetch package.

The nonce middleware relies now on @wordpress/hooks for listening to the heartbeat ticks events.

[mmtr]

cc @gziolo @ehg

[mmtr]

Not sure why I'm not receiving any output on the test-e2e run

> wp-scripts test-unit-js --config test/e2e/jest.config.json --runInBand
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

[gziolo]

We still need to properly update dependencies declared in PHP code. It's not the best experience to be honest. I can help with that.

[youknowriad]

I think this addition makes more sense as an addition to the heartbeat script instead of wp-api-fetch

[gziolo]

You would have also to add wp-hooks as a dependency of wp-api-fetch because it is now used in the code.

It might be more tricky to put it as part of heartbeat because of wp-hooks dependency.

[mmtr]

wp-hooks is now a dependency of wp-api-fetch

[youknowriad]

I still think ideally, this script should be attached to heartbeat. It's possible to do so https://wordpress.stackexchange.com/questions/100709/add-a-script-as-a-dependency-to-a-registered-script

This allows us to remove the jQuery dependency from the wp-api-fetch script handle as well. Ideally, we would port heartbeat to a gutenberg package and just do it in the code instead of an inline script.

Anyway, I'm fine with this change if we add a comment explaining what we should do ideally.

[gziolo]

Yes, good point. @mmtr let us know if you want to iterate or leave it as it is filing an issue to tackle it later.

[mmtr]

Thanks @youknowriad for the suggestion! 👍

I have moved the addition to the heartbeat script. Does it look good now?

I'm not very familiar yet with PHP or the WordPress API, so it may be possible I forgot something else. Let me know if that it's the case!

What I have not found is where the jQuery dependency is defined for the wp-api-fetch script. Where is it? It looks like only the wp-edit-post script is defining that dependency.

[gziolo]

There are 2 things to fix and we should be good to go.

Thanks for opening this PR, very anticipated change! 💯

[gziolo]

Can we rename api-fetch/createNonceMiddleware to core/api-fetch/create-nonce-middleware? It would make it more similar to other hooks.

[mmtr]

yeah, it makes sense. renamed!

[gziolo]

package-lock.json needs to be regenerated before we proceed. I would like also to get confirmation from @youknowriad that this solution can be used as is. Should we open a follow up maybe?

[mmtr]

package-lock.json needs to be regenerated before we proceed.

I already did this. Do you miss something?

[gziolo]

Looks great, thanks for the last set of improvements 🚢