Skip to content

Tests: Isolate deprecation warning state #83107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 3 commits into from
Sep 24, 2026
Merged

Tests: Isolate deprecation warning state #83107

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac636f8
Data: Isolate registerGenericStore warning tests
ciampo Sep 17, 2026
36ed604
Deprecated: Document unit testing deprecation warnings
ciampo Sep 24, 2026
06aed5a
Tests: Scope deprecation cleanup to each suite
ciampo Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/data/src/test/registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { logged } from '@wordpress/deprecated';
import { createRegistry } from '../registry';
import { createRegistrySelector } from '../factory';
import createReduxStore from '../redux-store';
import coreDataStore from '../store';

const REGISTER_GENERIC_STORE_DEPRECATION =
'wp.data.registerGenericStore is deprecated since version 5.9. Please use wp.data.register( storeDescriptor ) instead.';

describe( 'createRegistry', () => {
let registry;

Expand All @@ -27,6 +31,7 @@ describe( 'createRegistry', () => {

beforeEach( () => {
vi.useFakeTimers();
logged[ REGISTER_GENERIC_STORE_DEPRECATION ] = true;
registry = createRegistry();
} );

Expand All @@ -35,6 +40,7 @@ describe( 'createRegistry', () => {
while ( ( unsubscribe = unsubscribes.shift() ) ) {
unsubscribe();
}
delete logged[ REGISTER_GENERIC_STORE_DEPRECATION ];
vi.useRealTimers();
} );

Expand All @@ -50,6 +56,7 @@ describe( 'createRegistry', () => {
} );

it( 'should throw if not all required config elements are present', () => {
delete logged[ REGISTER_GENERIC_STORE_DEPRECATION ];
expect( () =>
registry.registerGenericStore( 'grocer', {} )
).toThrow();
Expand All @@ -65,7 +72,9 @@ describe( 'createRegistry', () => {
subscribe,
} )
).toThrow();
expect( console ).toHaveWarned();
expect( console ).toHaveWarnedWith(
REGISTER_GENERIC_STORE_DEPRECATION
);
} );

describe( 'getSelectors', () => {
Expand Down
Loading