Repository navigation
Block library: Isolate order-sensitive test interactions - #83101
Merged
Merged
Conversation
🤖 PR meta 🤖📦 Bundle sizeSize Change: 0 B Total Size: 8.22 MB
|
This was referenced Sep 22, 2026
ciampo
force-pushed
the
codex/vitest-order-blocks
branch
from
September 24, 2026 10:05
fee51ca to
e3ea5a3
Compare
ciampo
force-pushed
the
codex/vitest-order-block-library
branch
from
September 24, 2026 10:08
229b46a to
d3ab1bb
Compare
ciampo
force-pushed
the
codex/vitest-order-blocks
branch
from
September 24, 2026 10:32
e3ea5a3 to
28b923a
Compare
ciampo
force-pushed
the
codex/vitest-order-block-library
branch
from
September 24, 2026 10:34
d3ab1bb to
f517a48
Compare
ciampo
marked this pull request as ready for review
September 24, 2026 12:57
ciampo
requested review from
ellatrix,
fabiankaegy and
tellthemachines
as code owners
September 24, 2026 12:57
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Sep 24, 2026
widoz
pushed a commit
to widoz/gutenberg
that referenced
this pull request
Oct 2, 2026
…3101) * Block editor: Isolate mutable test fixtures * Blocks: Isolate registration state in tests * Blocks: Reset grouping block name after registration tests * Block library: Isolate order-sensitive test interactions * Block library: Load popover styles in Cover tests --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #80855 by isolating Columns test fixtures and loading the popover styles required by the Cover Browser tests.
Why?
Columns tests replaced a shared array. Seed 80855 also exposed a Cover fixture defect: the Full height toolbar button intercepted the content-position grid click because the fixture did not load the popover stacking styles. The content-position case passed alone but failed in the shuffled file. Resetting the pointer did not fix it.
How?
Columns uses local inputs. Cover imports the existing Popover and block-popover styles that WordPress normally enqueues separately. Both original pointer clicks and all assertions remain intact. The previous keyboard workaround is removed.
Testing Instructions
Repeat the Cover run with seeds 80856 and 80857. The toolbar must not intercept the matrix click, and the existing content-position assertions must pass.
Testing Instructions for Keyboard
No production UI changes. Existing keyboard cases are unchanged; content-position selection retains pointer coverage.
24 September rebase verification
Rebased onto the updated #83099 without changing this PR's patch. All 47 affected tests passed file and test shuffling at seeds
80855,80856, and80857. Focused lint and diff checks passed. The stack's production build passed on trunkb40716dc70b3; this PR changes test fixtures only.New-trunk refresh
Includes trunk's stricter console accounting (#83095). All 47 affected tests passed again with seeds 80855 and 80856. Both repair patches and assertions are unchanged.
Use of AI Tools
Codex reproduced the failures, performed an independent adversarial review, repaired the fixture setup, and ran verification.