Skip to content

Block library: Isolate order-sensitive test interactions - #83101

Merged
ciampo merged 5 commits into
trunkfrom
codex/vitest-order-block-library
Sep 24, 2026
Merged

ciampo merged 5 commits into
trunkfrom
codex/vitest-order-block-library

Conversation

@ciampo

@ciampo ciampo commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

What?

Follow up to #80855 by isolating Columns test fixtures and loading the popover styles required by the Cover Browser tests.

Why?

Columns tests replaced a shared array. Seed 80855 also exposed a Cover fixture defect: the Full height toolbar button intercepted the content-position grid click because the fixture did not load the popover stacking styles. The content-position case passed alone but failed in the shuffled file. Resetting the pointer did not fix it.

How?

Columns uses local inputs. Cover imports the existing Popover and block-popover styles that WordPress normally enqueues separately. Both original pointer clicks and all assertions remain intact. The previous keyboard workaround is removed.

Testing Instructions

npm run test:unit:vitest -- packages/block-library/src/columns/test/utils.js packages/block-library/src/cover/test/edit.browser.test.js
npm run test:unit:vitest -- --sequence.shuffle.files --sequence.shuffle.tests --sequence.seed=80855 packages/block-library/src/columns/test/utils.js packages/block-library/src/cover/test/edit.browser.test.js

Repeat the Cover run with seeds 80856 and 80857. The toolbar must not intercept the matrix click, and the existing content-position assertions must pass.

Testing Instructions for Keyboard

No production UI changes. Existing keyboard cases are unchanged; content-position selection retains pointer coverage.

24 September rebase verification

Rebased onto the updated #83099 without changing this PR's patch. All 47 affected tests passed file and test shuffling at seeds 80855, 80856, and 80857. Focused lint and diff checks passed. The stack's production build passed on trunk b40716dc70b3; this PR changes test fixtures only.

New-trunk refresh

Includes trunk's stricter console accounting (#83095). All 47 affected tests passed again with seeds 80855 and 80856. Both repair patches and assertions are unchanged.

Use of AI Tools

Codex reproduced the failures, performed an independent adversarial review, repaired the fixture setup, and ran verification.

@github-actions github-actions Bot added the [Package] Block library /packages/block-library label Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 8.22 MB

f517a48 Run

@ciampo ciampo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Sep 22, 2026
@ciampo
ciampo force-pushed the codex/vitest-order-blocks branch from fee51ca to e3ea5a3 Compare September 24, 2026 10:05
@ciampo
ciampo force-pushed the codex/vitest-order-block-library branch from 229b46a to d3ab1bb Compare September 24, 2026 10:08
@ciampo
ciampo force-pushed the codex/vitest-order-blocks branch from e3ea5a3 to 28b923a Compare September 24, 2026 10:32
@ciampo
ciampo force-pushed the codex/vitest-order-block-library branch from d3ab1bb to f517a48 Compare September 24, 2026 10:34
Base automatically changed from codex/vitest-order-blocks to trunk September 24, 2026 12:56
@ciampo ciampo self-assigned this Sep 24, 2026
@ciampo
ciampo marked this pull request as ready for review September 24, 2026 12:57
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo
ciampo merged commit eb3d77c into trunk Sep 24, 2026
76 checks passed
@ciampo
ciampo deleted the codex/vitest-order-block-library branch September 24, 2026 13:19
@github-actions github-actions Bot added this to the Gutenberg 24.2 milestone Sep 24, 2026
widoz pushed a commit to widoz/gutenberg that referenced this pull request Oct 2, 2026
…3101)

* Block editor: Isolate mutable test fixtures

* Blocks: Isolate registration state in tests

* Blocks: Reset grouping block name after registration tests

* Block library: Isolate order-sensitive test interactions

* Block library: Load popover styles in Cover tests

---

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Block library /packages/block-library [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants