Skip to content

Block Mover: Cleanup focus ring override #83068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
im3dabasia merged 7 commits into from
Sep 17, 2026
Merged

Block Mover: Cleanup focus ring override #83068

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
57b7772
fix: remove focus ring overides from blockmover
yashjawale Sep 17, 2026
8cea772
Merge branch 'trunk' into fix/focus-ring-block-mover-80138
yashjawale Sep 17, 2026
5ddb4c1
Merge branch 'trunk' into fix/focus-ring-block-mover-80138
yashjawale Sep 17, 2026
333f96b
fix: remove list-view adjustment for block mover buttons focus ring
yashjawale Sep 17, 2026
72d9db3
Merge branch 'trunk' into fix/focus-ring-block-mover-80138
yashjawale Sep 17, 2026
b494127
fix: update comment to reflect change
yashjawale Sep 17, 2026
79e74bc
Merge branch 'trunk' into fix/focus-ring-block-mover-80138
yashjawale Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/block-editor/src/components/block-mover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,4 @@
animation-fill-mode: forwards;
}
}

// Don't show the focus inherited by the Button component.
&:focus,
&:focus:enabled,
// Override focus styles from the block toolbar
&:focus::before {
box-shadow: none;
outline: none;
}

&:focus-visible::before {
@include block-toolbar-button-style__focus();
}
Comment on lines -109 to -111

@im3dabasia im3dabasia Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this matches #82337 👍 The testing steps only cover Storybook. Could you also check the mover in the editor's block toolbar and add a screenshot there?

@im3dabasia im3dabasia Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, is the ::before tweak in list-view/style.scss#L384-L390 still needed?

If not, it could be removed here too.

@yashjawale yashjawale Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh right. Even though the ::before element still exists, I tried setting the ListViewComponent component to have showBlockMovers enabled by default so it shows those controls. I didn't see any difference in their appearance in post editor's list view panel.

With those lines present:

image

Without:

image

Updated to remove those lines & also updated the description to have screenshots from editor too.

Thanks! 🙌

}
8 changes: 0 additions & 8 deletions packages/block-editor/src/components/list-view/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,14 +380,6 @@
top: -$grid-unit-05;
}
}

// Tweak size and position of focus ring.
&::before {
height: 16px;
min-width: 100%;
left: 0;
right: 0;
}
}

.block-editor-inserter__toggle {
Expand Down
Loading