Repository navigation
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. 📦 Bundle sizeSize Change: 0 B Total Size: 8 MB
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsShow the failuresSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. refuses the drop and uploads nothing in
|
Contributor
Author
|
@WordPress/gutenberg-components @manzoorwanijk this PR was mostly a test to see if certain Vitest flags would result in faster test run, but it looks like they're mostly inconclusive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #82687.
Prototype a nested Vitest project for the Node and jsdom suites so they inherit one configuration and share one Vite server. Browser Mode remains a separate project.
This also re-tests
fsModuleCache; it is not enabled by this PR.Why?
Node and jsdom currently build separate Vite module graphs. Vitest 5 can share a server between nested inline projects, but the first prototype rooted its referenced configuration under
test/unitand discovered no integration tests.How?
Benchmark notes
On the #82687 merge commit, five alternating runs used shard 1/8, four workers, seed 80855, and the same 134 files / 3,476 tests each time.
The shared server improved the median by 9.0%, but two slow samples made the mean 7.0% worse. This remains a prototype rather than a stable performance claim.
A separate three-run warm-cache comparison improved both the median (42.6s vs 46.0s) and mean (43.9s vs 47.3s). However, priming took 97.0s, the single-shard cache occupied 84 MB across 5,959 files, and
fsModuleCachedoes not support Browser Mode. It remains disabled.Testing Instructions
npm run test:unit:routing. Confirm it validates 1,071 Vitest files, with every test assigned exactly once.DEBUG=vitest:projects npm exec --no -- vitest list --config=test/unit/vitest.config.mjs --filesOnly. Confirmunit (jsdom)reuses the Vite server created forunit (node)and Browser Mode creates a separate server.npm run test:unit:vitest -- --project='unit (node)' test/unit/scripts/test/discover-test-files.test.js test/unit/scripts/test/test-infrastructure-policy.test.js.npm run test:unit:vitest -- --project='browser (chromium)'.npm run buildandnpm run typecheck.Testing Instructions for Keyboard
Not applicable. This PR does not change UI behavior.
Screenshots or screencast
Not applicable.
Use of AI Tools
Codex was used to prototype the configuration, add tests, run benchmarks, and draft this PR. The resulting diff and verification output were reviewed before publication.