Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion storybook/tsconfig.docgen.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,14 @@
"rootDir": ".."
},
"references": [],
"include": [ "**/*.ts", "**/*.tsx", "../packages/*/src/**/*" ]
"include": [ "**/*.ts", "**/*.tsx", "../packages/*/src/**/*" ],
// Override the base exclusions to admit stories without also admitting tests.
"exclude": [
"../**/benchmark",
"../packages/*/build-*/**",
"../packages/*/build/**",
"../**/test/**",
"../**/tests/**",
"../**/__tests__/**"
]
Comment on lines +12 to +17

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a risk of drift here between patterns in the base config and here. I don't know that I have any great suggestions. Part of my AI review pointed at tools/validation/validate-tsconfig.mjs as a place we could validate.

I also wonder... do we need all of these? We may not need the build patterns here if we're already scoping to src/ plus .tsx? files. Separately we should also see if we can remove additional test patterns across the board around test pattern variations. That could help lessen the drift risk.

Not a blocker.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I removed the two redundant build exclusions. The three test-directory variants still match files in the repository, so I kept their broader consolidation out of this PR.

}
Loading