Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a risk of drift here between patterns in the base config and here. I don't know that I have any great suggestions. Part of my AI review pointed at
tools/validation/validate-tsconfig.mjsas a place we could validate.I also wonder... do we need all of these? We may not need the
buildpatterns here if we're already scoping tosrc/plus.tsx?files. Separately we should also see if we can remove additional test patterns across the board aroundtestpattern variations. That could help lessen the drift risk.Not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I removed the two redundant build exclusions. The three test-directory variants still match files in the repository, so I kept their broader consolidation out of this PR.