Skip to content

Tests: Recognize Chromium browser project in routing validation - #82568

Closed
ciampo wants to merge 4 commits into
trunkfrom
codex/browser-test-routing
Closed

ciampo wants to merge 4 commits into
trunkfrom
codex/browser-test-routing

Conversation

@ciampo

@ciampo ciampo commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Based on #82567. Required by the browser tests for #66806.

What?

Allow the routing validator to recognize Vitest's configured Chromium browser instance.

Why?

Adding a browser test makes npm run test:unit:routing fail with Unexpected Vitest project browser (chromium), even though the test belongs to the configured browser project.

How?

Map that exact instance name to browser. Keep the existing checks for unknown projects, missing files, and duplicate test ownership.

Testing Instructions

  1. Add a temporary test/unit/scripts/test/routing.browser.test.js containing import { test } from 'vitest'; test( 'browser routing', () => {} );.
  2. Run npm run test:unit:routing. It should recognize the browser test and validate one runner per test file.
  3. Remove the temporary test and run the command again.
Verification

Reproduced the failure with the component migration's browser tests. With this change, routing validates all 1,106 test files: 38 Jest and 1,068 Vitest. JavaScript lint passes.

Use of AI Tools

Authored and verified with Codex.

@github-actions

github-actions Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

📦 Bundle size

Size Change: 0 B

Total Size: 8 MB

c2b5092 Run

@ciampo

ciampo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #82574

@ciampo ciampo closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant