Repository navigation
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. 📦 Bundle sizeSize Change: 0 B Total Size: 8 MB
|
This was referenced Sep 7, 2026
ciampo
force-pushed
the
codex/emotion-scss-migration-skill
branch
from
September 8, 2026 14:12
50f63ac to
9789db6
Compare
Contributor
Author
|
Closing as superseded by #82574 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #82567. Required by the browser tests for #66806.
What?
Allow the routing validator to recognize Vitest's configured Chromium browser instance.
Why?
Adding a browser test makes
npm run test:unit:routingfail withUnexpected Vitest project browser (chromium), even though the test belongs to the configured browser project.How?
Map that exact instance name to
browser. Keep the existing checks for unknown projects, missing files, and duplicate test ownership.Testing Instructions
test/unit/scripts/test/routing.browser.test.jscontainingimport { test } from 'vitest'; test( 'browser routing', () => {} );.npm run test:unit:routing. It should recognize the browser test and validate one runner per test file.Verification
Reproduced the failure with the component migration's browser tests. With this change, routing validates all 1,106 test files: 38 Jest and 1,068 Vitest. JavaScript lint passes.
Use of AI Tools
Authored and verified with Codex.