Skip to content

Fix/82273 note toolbar participants - #82519

Closed
pranvinit wants to merge 3 commits into
WordPress:trunkfrom
pranvinit:fix/82273-note-toolbar-participants
Closed

pranvinit wants to merge 3 commits into
WordPress:trunkfrom
pranvinit:fix/82273-note-toolbar-participants

Conversation

@pranvinit

Copy link
Copy Markdown
Contributor

What?

Closes #82273.

Show participants across all relevant note threads in the block toolbar.

Why?

The indicator showed only one thread’s participants, hiding users who contributed to other threads on the same block.

How?

Aggregate and deduplicate authors and repliers across unresolved threads, falling back to resolved threads when necessary. Preserve navigation and avatar overflow behavior.

Testing Instructions

  1. Using two users, add block-level and inline notes to the same block.
  2. Confirm both users appear in the toolbar indicator.
  3. Resolve, reopen, or delete a thread and verify the avatars update.
  4. With four participants, confirm two avatars and +2 appear.

Validation: 104 focused tests and changed-file lint passed. Build and E2E checks were not run.

Testing Instructions for Keyboard

Navigate to “View notes” in the block toolbar. Activate it with Enter or Space and confirm focus moves to the primary note thread.

Screenshots or screencast

Not included.

Use of AI Tools

Codex assisted with implementation, tests, documentation, and this PR description.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include @coderabbitai review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 1a39c02e-2eb2-4509-884b-f9207b27cffc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the [Package] Editor /packages/editor label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

@Mamaduka

Mamaduka commented Sep 7, 2026

Copy link
Copy Markdown
Member

Thanks for contributing, @pranvinit!

I see that the linked issue already has a PR (#82357. What's the reason for creating a separate one? It's not clear why this alternative is better.

I would recommend contributing by testing/reviewing similar cases.

@Mamaduka

Mamaduka commented Oct 1, 2026

Copy link
Copy Markdown
Member

Closing this in favor of original PR.

@Mamaduka Mamaduka closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Editor /packages/editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notes: toolbar avatar indicator only shows one thread's participants when a block has multiple notes

2 participants