Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
🤖 PR meta 🤖📦 Bundle sizeSize Change: 0 B Total Size: 8.01 MB
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
|
Member
Author
|
I will continue to sweep the entire package after this. |
Member
Author
|
It's becoming clearer to me that maintaining public CSS variables like this "just in case" isn't worth the cost at the moment, and is better to remove as a YAGNI. I will pivot to removal strategy (cc @WordPress/gutenberg-components). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Start the
--wp-ui-*default-via-fallback convention, convertingCheckboxas the first stylesheet.Why?
--wp-ui-*custom properties are public API. They inherit. If a component assigns the default on the class that uses the variable, that assignment overwrites any ancestor value, so consumers cannot theme from a wrapper.#81242 is the prior instance of this, for
--focus-coloronoutset-ring__focus.How?
--wp-ui-checkbox-input-size: 16pxfrom.root. Readvar(--wp-ui-checkbox-input-size, 16px)onwidthand useaspect-ratio: 1for the square.--wp-ui-*defaults inpackages/ui/CONTRIBUTING.md.Testing Instructions
--wp-ui-checkbox-input-size: 32pxon a parent of the checkbox. The box should become 32px by 32px.Screenshots
No visual changes.