Skip to content

Test: Prepare TypeScript test graphs for Vitest #82210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 1 commit into from
Aug 31, 2026
Merged

Test: Prepare TypeScript test graphs for Vitest #82210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compose/src/higher-order/pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
*/
const basePipe =
( reverse: boolean = false ) =>
( ...funcs: Function[] ) =>
( ...funcs: ( Function | Function[] )[] ) =>

@manzoorwanijk manzoorwanijk Aug 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation below uses funcs.flat(), which means that it always expects an array. 🤔

@ciampo ciampo Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...funcs always creates an array, but Function[] means every argument must itself be a function.

Existing tests support all these forms:

pipe( a, b, c );
pipe( [ a, b, c ] );
pipe( [ a, b ], c, [ d ], e );

That is why we need ( Function | Function[] )[]. The .flat() call normalizes those mixed arguments. Without the change, the downstream validator reports four type errors.

@manzoorwanijk manzoorwanijk Aug 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I don't know why I didn't notice the ... rest operator 🤦

All good.

@ciampo ciampo Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many PRs in our inboxes 👀 Pace is hectic

( ...args: unknown[] ) => {
const functions = funcs.flat();
if ( reverse ) {
Expand Down
Loading