Skip to content

Site editor v2: Fix block error with navigation-edit route #82051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 1 commit into from
Aug 26, 2026
Merged

Site editor v2: Fix block error with navigation-edit route #82051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions routes/navigation-edit/editor/leaf-more-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ const POPOVER_PROPS = {
};

export default function LeafMoreMenu( {
block,
clientId,
...props
}: {
block: { clientId: string; name: string };
clientId: string;
} ) {
const { clientId } = block;
const {
moveBlocksDown,
moveBlocksUp,
Expand All @@ -38,6 +37,7 @@ export default function LeafMoreMenu( {
( select ) => {
const {
getBlockRootClientId,
getBlockName,
canInsertBlockType,
getDirectInsertBlock,
getBlockIndex,
Expand All @@ -46,6 +46,7 @@ export default function LeafMoreMenu( {
const { getDefaultBlockName } = select( blocksStore );

const _rootClientId = getBlockRootClientId( clientId );
const _blockName = getBlockName( clientId );
const canInsertDefaultBlock = canInsertBlockType(
getDefaultBlockName(),
_rootClientId
Expand All @@ -57,20 +58,18 @@ export default function LeafMoreMenu( {
return {
rootClientId: _rootClientId,
canDuplicate:
!! block &&
hasBlockSupport( block.name, 'multiple', true ) &&
canInsertBlockType( block.name, _rootClientId ),
hasBlockSupport( _blockName, 'multiple', true ) &&
canInsertBlockType( _blockName, _rootClientId ),
canInsertBlock:
( canInsertDefaultBlock || !! directInsertBlock ) &&
!! block &&
canInsertBlockType( block.name, _rootClientId ),
canInsertBlockType( _blockName, _rootClientId ),
isFirst: getBlockIndex( clientId ) === 0,
isLast:
getBlockIndex( clientId ) ===
getBlockCount( _rootClientId ) - 1,
};
},
[ clientId, block ]
[ clientId ]
);

return (
Expand Down
Loading