Skip to content

Button: Fix alignment in loading spinner for rtl screens #81901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
im3dabasia merged 2 commits into from
Aug 24, 2026
Merged

Button: Fix alignment in loading spinner for rtl screens #81901

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc71d33
fix: Button rtl loader issue
im3dabasia Aug 21, 2026
61adcbc
Merge branch 'trunk' into fix/ui-button-loading-spinner-rtl
im3dabasia Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

- `Autocomplete.Input`, `Combobox.Input`: Omit the `type` prop, since the combobox role is only valid on `input type="text"` ([#80636](https://github.com/WordPress/gutenberg/pull/80636)).
- `Card`: Use the normal neutral surface stroke for the default border. ([#81746](https://github.com/WordPress/gutenberg/pull/81746))
- `Button`: Fix the loading spinner being off-center in RTL, where the direction-aware anchor and the direction-unaware `transform` shifted it the same way instead of back toward center ([#81887](https://github.com/WordPress/gutenberg/issues/81887)).

@juanfra juanfra Aug 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `Button`: Fix the loading spinner being off-center in RTL, where the direction-aware anchor and the direction-unaware `transform` shifted it the same way instead of back toward center ([#81887](https://github.com/WordPress/gutenberg/issues/81887)).
- `Button`: Fix the loading spinner being off-center in RTL ([#81901](https://github.com/WordPress/gutenberg/pull/81901)).


### Documentation

Expand Down
3 changes: 2 additions & 1 deletion packages/ui/src/button/style.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@
content: "";
position: absolute;
top: 50%;
inset-inline-start: 50%;
/* stylelint-disable-next-line plugin/use-logical-properties-and-values -- Physical centering technique used with transform: translate(-50%, -50%) */
left: 50%;
transform: translate(-50%, -50%);

display: block;
Expand Down
Loading