Repository navigation
Grid: per-item tile size limits #81899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
42c256e
add per-item minimum sizes to grid surfaces
retrofox 39f2b6a
add per-item minimum sizes story to the grid
retrofox ec8058c
generalize per-item minimums into size limits
retrofox 4723bf3
demonstrate size limits per grid model
retrofox 658b162
Merge remote-tracking branch 'origin/trunk' into update/grid-tile-limits
retrofox 1e19dd6
anchor full-width resize at the capped span
retrofox 9146e28
exercise full and fill widths in the limits story
retrofox 20463e0
plan fill widths around item span bounds
retrofox b9417ed
tune the limit stories to twelve columns
retrofox 6a7b2d6
Merge branch 'trunk' into update/grid-tile-limits
retrofox f0ade54
link the grid changelog to its pull request
retrofox f033787
Merge remote-tracking branch 'origin/trunk' into update/grid-tile-limits
retrofox 93b4260
keep span bounds identity stable across geometry ticks
retrofox 594de0a
place capped full items like fixed items in the fill plan
retrofox 2031dac
document item limits in the grid readme and trim the jsdoc
retrofox b692591
add a tile bounded on both ends to the size limits stories
retrofox 74112c7
mark the size limits stories as a11y todo
retrofox d3e0a1a
Merge remote-tracking branch 'origin/trunk' into update/grid-tile-limits
retrofox 73e323d
derive grid commits from the stored layout
retrofox 23d42d7
resize lanes from the rendered span
retrofox b440755
narrow lanes item limits to the width axis
retrofox b151ee7
Merge remote-tracking branch 'origin/trunk' into update/grid-tile-limits
retrofox aacd4ca
Update packages/grid/README.md
retrofox dfd9ca8
Merge remote-tracking branch 'origin/trunk' into update/grid-tile-limits
retrofox 8840eac
docs: grid height limits need a numeric rowHeight
retrofox 6e732ab
Merge remote-tracking branch 'origin/update/grid-tile-limits' into up…
retrofox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should the example set a numeric
rowHeight? I noticed height limits are skipped whenrowHeightis 'auto', which is the default, sominHeight: 200here may be a no-op.