Skip to content

Global Styles: Group shadow editor rows as items #81871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 3 commits into from
Aug 20, 2026
Merged

Global Styles: Group shadow editor rows as items #81871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccafd4d
Global Styles: Group shadow editor rows as items
ciampo Aug 20, 2026
37bc356
Global Styles: Add shadow row fix changelog
ciampo Aug 20, 2026
638fc3b
Global Styles: Remove shadow editor E2E test
ciampo Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/global-styles-ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
- Expose typography and color controls for citations, inputs, and selects in Global Styles ([#80852](https://github.com/WordPress/gutenberg/pull/80852)).
- Mark blocks that have user styles in the block list, and add a filter to show only those blocks ([#81373](https://github.com/WordPress/gutenberg/pull/81373)).

### Bug Fixes

- Shadow editor: Group each row as one item so separators do not cross row actions ([#81871](https://github.com/WordPress/gutenberg/pull/81871)).

### Internal

- Exclude the JavaScript tests and story from the build project so their declarations are not published. ([#81516](https://github.com/WordPress/gutenberg/pull/81516))
Expand Down
19 changes: 10 additions & 9 deletions packages/global-styles-ui/src/shadows-edit-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,15 +222,16 @@ function ShadowEditor( { shadow, onChange }: ShadowEditorProps ) {
<Spacer />
<ItemGroup isBordered isSeparated>
{ shadowParts.map( ( part, index ) => (
<ShadowItem
key={ index }
shadow={ part }
onChange={ ( value ) =>
onChangeShadowPart( index, value )
}
canRemove={ shadowParts.length > 1 }
onRemove={ () => onRemoveShadowPart( index ) }
/>
<div key={ index } role="listitem">
<ShadowItem
shadow={ part }
onChange={ ( value ) =>
onChangeShadowPart( index, value )
}
canRemove={ shadowParts.length > 1 }
onRemove={ () => onRemoveShadowPart( index ) }
/>
</div>
) ) }
</ItemGroup>
</>
Expand Down
4 changes: 0 additions & 4 deletions packages/global-styles-ui/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,6 @@
top: 8px;
opacity: 0;

&.global-styles-ui__shadow-editor__remove-button {
border: none;
}

.global-styles-ui__shadow-editor__dropdown-toggle:hover + &,
&:focus,
&:hover {
Expand Down
Loading