Repository navigation
Conversation
|
Size Change: 0 B Total Size: 7.73 MB |
ciampo
force-pushed
the
codex/menu-slotfill-compatibility
branch
from
September 1, 2026 16:56
b97c341 to
c56ea30
Compare
🤖 PR meta 🤖📦 Bundle sizeSize Change: 0 B Total Size: 7.91 MB
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
|
Contributor
Author
|
cc @Mamaduka for an early look |
Member
|
This looks like a good start! A couple of quick notes:
|
Contributor
Author
Sounds like a plan! I'm also going to start refactoring a few |
19 of 59 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #79560.
See #61094, #81507, and #81564.
What?
Adds a Storybook migration guide for menus that receive items through SlotFill or another extension API, and links it from Menu's component status.
Why?
Gutenberg can bundle separate copies of
@wordpress/uiinto the menu owner and extension packages. Their Menu parts do not share React context, so the owner needs a compatibility layer that preserves the extension API's existing behavior.The Options menu migration in #81564 exposed compatibility details that a simplified adapter would miss, including checked states, accessible names, links, shortcuts, icons, and custom renderers.
How?
Documents a host-owned adapter passed through
ActionItem.Slot, with the slot'schildrencallback composing the rendered items into the new menu. The guide requires an audit and public-path tests for the legacy item contract. It treats arbitrary custom renderers as a separate deprecation or release-policy decision.It also adds the documentation changelog entry under the current unreleased section.
Testing Instructions
npm run storybook:dev.ActionItem.Slotcomposition, legacy item compatibility, custom renderers, testing, and migration order.Testing Instructions for Keyboard
Documentation-only change. Verify that links in the Menu status note and migration guide can be reached and activated with the keyboard.
Use of AI Tools
This PR was implemented with AI assistance in Codex and reviewed locally.