Repository navigation
Media: Detect HEIC uploads from the file header rather than the file name #81737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e781637
Media: Add e2e coverage for a HEIC file uploaded with the wrong exten…
adamsilverstein 90d400a
Media: Detect HEIC uploads from the file header rather than the file …
adamsilverstein 5afd7f0
Merge remote-tracking branch 'origin/trunk' into fix/81707-heic-wrong…
adamsilverstein ab15cfa
Media: Cover the HEIC-only upload path in Chromium instead of WebKit
adamsilverstein 668178a
Merge remote-tracking branch 'origin/trunk' into fix/81707-heic-wrong…
adamsilverstein 7d3b7a6
Merge remote-tracking branch 'origin/trunk' into fix/81707-heic-wrong…
adamsilverstein 7c150a6
Merge remote-tracking branch 'origin/trunk' into fix/81707-heic-wrong…
adamsilverstein 1914176
Tests: Import Vitest globals in the HEIC buffer test
adamsilverstein 60767e6
Tests: Replace leftover Jest globals with their Vitest equivalents
adamsilverstein 0dd3ce9
Tests: Expect a processing error for an unparseable HEIC fixture
adamsilverstein b02af6c
Merge branch 'trunk' into fix/81707-heic-wrong-extension
adamsilverstein 8545a61
Merge remote-tracking branch 'origin/trunk' into fix/81707-heic-wrong…
adamsilverstein 66c4e0b
Media: Bound the ImageDecoder HEIC decode with a timeout
singhakanshu00 a10c5de
Media: Fall through only when the ImageDecoder decode times out
adamsilverstein 06558bf
Media: Fix prettier formatting in prepareItem
adamsilverstein 4d7046c
Update packages/upload-media/src/store/test/actions.ts
adamsilverstein 673f897
Update packages/upload-media/src/store/test/actions.ts
adamsilverstein d3baab4
Apply batched suggestions from code review
adamsilverstein 426f9fb
Merge remote-tracking branch 'origin/trunk' into fix/81707-heic-wrong…
adamsilverstein 5b1a83c
Media: Link the HEIC changelog entries to the PR and file them under …
adamsilverstein 6143369
Media: Read HEIC brands only from inside the File Type Box
adamsilverstein d9be887
Merge branch 'trunk' into fix/81707-heic-wrong-extension
t-hamano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to link the changelog to the PR rather than the issue, as it makes it clearer what changes were actually made. Additionally, this entry needs to be moved to the
Unreleasedsection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I see that in the guidelines now. Will update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, with one small deviation from the suggestion.
Claude made the changelog edits, its summary: