Repository navigation
Editor: Announce publish date changes to screen readers #81629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for using "assertive" instead of the default "polite"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think direct actions are announced with "assertive" - "block inserter", "link removed", etc. Those all use assertive.
It would be nice to have a brief guideline on which politeness level to use in each case. Recently, I swapped "assertive" for "polite" to announce category filtering results (#81422), which seems to be the pattern in the project, but now I see more places using "assertive".
@joedolson, is this something we can document in guidelines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely try and identify guidelines. It's all about immediacy: a polite announcement will be deferred until after other speaking has completed, and an assertive announcement will be announced immediately, interrupting other announcements. The complicating factor is that the length of other ongoing announcements is going to be a mitigating factor. For example, if the active element has a lengthy
aria-describedbytarget, and apoliteannouncement, that announcement will be quite a while later - and may never be announced, if the user interrupts speaking before it happens.I'll chat with the rest of the team and try and set some guidelines that we can attempt to apply generally, so that we have some consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joedolson!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all, thank you for the discussion.
"Assertive" was chosen because this is a confirmation of a direct user action, which seems to be the existing pattern in the project, as @Mamaduka noted e.g., "Link removed." / "Link inserted." in the link UI, "%s applied." / "%s removed." when toggling formats, and the added/removed messages in FormTokenField. "Polite" seems to be reserved for background or asynchronous updates, e.g., "Media upload started" / "Media upload complete", or result counts after filtering.
I think we can go with assertive but I am happy to change after if it does not matches the guidelines.