Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the embed block to support all WP_oEmbed embeds #816

Merged
merged 16 commits into from
Jun 2, 2017
Merged

Enhance the embed block to support all WP_oEmbed embeds #816

merged 16 commits into from
Jun 2, 2017

Commits on Jun 1, 2017

  1. Updated the embed block to use the oembed proxy API 

    Added "html-embed" component which embeds html from the
ombed proxy inside a div and makes sure any script elements
get run. This initial version uses a div instead of a
sandbox iframe due to some tricky rendering issues with
reactive embdedded content from sites like tumblr.
    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    f9d17bc View commit details
    Browse the repository at this point in the history

  2. Lint fixes

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    2723e86 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    d071080 View commit details
    Browse the repository at this point in the history

  4. Fix initial render of the embed block when loading a saved post

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    6fea1e8 View commit details
    Browse the repository at this point in the history

  5. Polish the embed placeholder a bit.

    @jasmussen @notnownikki
    jasmussen authored and notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    830b743 View commit details
    Browse the repository at this point in the history

  6. Fix video and "other" ambiguation. 

    This makes videos responsive again.
    @jasmussen @notnownikki
    jasmussen authored and notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    b99e42c View commit details
    Browse the repository at this point in the history

  7. Address a couple of PR review items 

    - Use spinner component
- Adjust some parenthesis syntax
    @jasmussen @notnownikki
    jasmussen authored and notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    c55973f View commit details
    Browse the repository at this point in the history

  8. Fixed components import

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    540c43c View commit details
    Browse the repository at this point in the history

  9. Adds wpApiSettings to the globals in .eslintrc.json

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    42172c0 View commit details
    Browse the repository at this point in the history

  10. Deal with the component unmounting while a fetch is ongoing

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    ea6ff87 View commit details
    Browse the repository at this point in the history

  11. Comment explaining the purpose of HtmlEmbed component

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    19f8477 View commit details
    Browse the repository at this point in the history

  12. Remove default prop in HtmlEmbed

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    f09a47f View commit details
    Browse the repository at this point in the history

  13. New script element creation tidied up

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    a235861 View commit details
    Browse the repository at this point in the history

  14. Lint fix

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    d934958 View commit details
    Browse the repository at this point in the history

  15. Fix typo

    @notnownikki
    notnownikki committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    316fb7d View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2017

  1. Fixed comment style

    @notnownikki
    notnownikki committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    58acca1 View commit details
    Browse the repository at this point in the history